From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZtdI5-0000Cr-Fu
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 10:14:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZtdI4-0002NZ-Gg
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 10:14:29 -0500
References: <cover.1446546057.git.berto@igalia.com>
	<4281ab6e201096ffd162a4ffc5b384d894475ff4.1446546057.git.berto@igalia.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <5638CF49.5040901@redhat.com>
Date: Tue, 3 Nov 2015 08:14:17 -0700
MIME-Version: 1.0
In-Reply-To: <4281ab6e201096ffd162a4ffc5b384d894475ff4.1446546057.git.berto@igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="v44vBWgIh1thFWeEmU3ublEOuX1SgElU1"
Subject: Re: [Qemu-devel] [PATCH v3 3/3] block: test 'blockdev-snapshot'
 using a file BDS as the overlay
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--v44vBWgIh1thFWeEmU3ublEOuX1SgElU1
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 11/03/2015 03:32 AM, Alberto Garcia wrote:
> This test checks that it is not possible to create a snapshot if the
> requested overlay node is a BDS which does not support backing images.
>=20
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  tests/qemu-iotests/085     | 12 +++++++++++-
>  tests/qemu-iotests/085.out |  4 ++++
>  2 files changed, 15 insertions(+), 1 deletion(-)
>=20

> +++ b/tests/qemu-iotests/085.out
> @@ -62,6 +62,10 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D=
134217728 backing_file=3DTEST_DIR/
>  {"return": {}}
>  {"return": {}}
> =20
> +=3D=3D=3D Invalid command - cannot create a snapshot using a file BDS =
=3D=3D=3D
> +
> +{"error": {"class": "GenericError", "desc": "The snapshot does not sup=
port backing images"}}

This message could use improvement; more on that in 1/3.

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--v44vBWgIh1thFWeEmU3ublEOuX1SgElU1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWOM9JAAoJEKeha0olJ0Nq9fIH/RoNq2s59gHnYpp5RzdoHjme
IGgYdcEKOpCQI8coyT4lQEuxyNXxsuOceoDI5+yLQsXx2HP2J7d17EXuSU7bpOVn
2QJmS8M1ANKEmf3hv0ZkmW6HCta/yhVX+Pw6g2Tq0hJCJbcW69laZqArMeS51mGI
TtSW+rnjWO0nf/hXpfEyufe5fjXgLO59PbZYEhoUv4SxN7cyQWViNIQnia+CPq5G
cRYMkpAFgSniZqzNGeJBg936hWrwRYEyg17f4OyFtQIiME1KXqiQ/ofX/GuAUMuw
uWnPpc2VVVYjiS6GpmvY6XI6MsV+94dp6b6nMn7ngA7IwAfxB49JNNfZnXwRBFE=
=H8lg
-----END PGP SIGNATURE-----

--v44vBWgIh1thFWeEmU3ublEOuX1SgElU1--