From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtdQa-0005KX-NG for qemu-devel@nongnu.org; Tue, 03 Nov 2015 10:23:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtdQV-0005cw-4h for qemu-devel@nongnu.org; Tue, 03 Nov 2015 10:23:16 -0500 References: <1445644612-12702-1-git-send-email-jsnow@redhat.com> <1445644612-12702-13-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <5638D157.5070503@redhat.com> Date: Tue, 3 Nov 2015 08:23:03 -0700 MIME-Version: 1.0 In-Reply-To: <1445644612-12702-13-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1ediVFcDBtMHDOrntjEDTLu5HprI4F0Uq" Subject: Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: vsementsov@virtuozzo.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1ediVFcDBtMHDOrntjEDTLu5HprI4F0Uq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/23/2015 05:56 PM, John Snow wrote: > Add both transactional properties to the QMP transactional interface, > and add the BlockJobTxn that we create as a result of the err-cancel > property to the BlkActionState structure. >=20 > [split up from a patch originally by Stefan and Fam. --js] > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > Signed-off-by: John Snow >=20 > Signed-off-by: John Snow Double S-o-b looks odd. > --- > blockdev.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++= +++++--- > qapi-schema.json | 48 +++++++++++++++++++++++++++++++--- > qmp-commands.hx | 2 +- > 3 files changed, 120 insertions(+), 8 deletions(-) >=20 > +## > # @transaction > # > # Executes a number of transactionable QMP commands atomically. If any= > # operation fails, then the entire set of actions will be abandoned an= d the > # appropriate error returned. > # > -# List of: > -# @TransactionAction: information needed for the respective operation= > +# @actions: List of @TransactionAction; > +# information needed for the respective operations. > +# > +# @properties: Optional structure of additional options to control the= Elsewhere, we've spelled it '#optional'; Marc-Andre has patches that rely on that spelling to turn it .json into documentation. But otherwise, looks good on first glance. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1ediVFcDBtMHDOrntjEDTLu5HprI4F0Uq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWONFYAAoJEKeha0olJ0Nq4XsIAKYJPnORu/rhnNjxUWqKfe0X As0y22QLC8b4NYMPx51ICZIKL4f9b7g/XVseH5CK/ND0zg6GlR3jrF4f+tbxz1MT ScN+REAT5dyuqK8gYDt7O53L2su4SCceEAkxBYRqJjRLkMzhu6RXvqAOjl6op3SY qZHlR0N4u5Fya2Wz6ECoUi8/xDWLet+uWyqfqalg+wKxsMJCC1iw3Fsq8X103A8W nzj8m6NST5MN36AZrJXAMeMkkAxvj2QfcV0254AlJ7Ljjx2tVyQ/sT0gw2QaA9Q1 tL1Es6lZFi0nO50Zu70BZ0ExFHOeQFzhWXBVXt1hWAvOj/8pRcKXLKjMcVcxI0o= =+kvp -----END PGP SIGNATURE----- --1ediVFcDBtMHDOrntjEDTLu5HprI4F0Uq--