From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtfQh-0002TP-Rk for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:31:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtfQg-00009a-QD for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:31:31 -0500 References: <1445644612-12702-1-git-send-email-jsnow@redhat.com> <1445644612-12702-13-git-send-email-jsnow@redhat.com> <5638D157.5070503@redhat.com> From: John Snow Message-ID: <5638EF6C.3080603@redhat.com> Date: Tue, 3 Nov 2015 12:31:24 -0500 MIME-Version: 1.0 In-Reply-To: <5638D157.5070503@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: vsementsov@virtuozzo.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org On 11/03/2015 10:23 AM, Eric Blake wrote: > On 10/23/2015 05:56 PM, John Snow wrote: >> Add both transactional properties to the QMP transactional interface, >> and add the BlockJobTxn that we create as a result of the err-cancel >> property to the BlkActionState structure. >> >> [split up from a patch originally by Stefan and Fam. --js] >> Signed-off-by: Stefan Hajnoczi >> Signed-off-by: Fam Zheng >> Signed-off-by: John Snow >> >> Signed-off-by: John Snow > > Double S-o-b looks odd. > >> --- >> blockdev.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++--- >> qapi-schema.json | 48 +++++++++++++++++++++++++++++++--- >> qmp-commands.hx | 2 +- >> 3 files changed, 120 insertions(+), 8 deletions(-) >> > > >> +## >> # @transaction >> # >> # Executes a number of transactionable QMP commands atomically. If any >> # operation fails, then the entire set of actions will be abandoned and the >> # appropriate error returned. >> # >> -# List of: >> -# @TransactionAction: information needed for the respective operation >> +# @actions: List of @TransactionAction; >> +# information needed for the respective operations. >> +# >> +# @properties: Optional structure of additional options to control the > > Elsewhere, we've spelled it '#optional'; Marc-Andre has patches that > rely on that spelling to turn it .json into documentation. > > But otherwise, looks good on first glance. > Do you mean: "# @properties: #optional structure of "... ? --js