From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtfV4-0007kg-0Z for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:36:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtfV0-0001Td-S3 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:36:01 -0500 References: <1445644612-12702-1-git-send-email-jsnow@redhat.com> <1445644612-12702-13-git-send-email-jsnow@redhat.com> <5638D157.5070503@redhat.com> <5638EF6C.3080603@redhat.com> From: Eric Blake Message-ID: <5638F074.5010704@redhat.com> Date: Tue, 3 Nov 2015 10:35:48 -0700 MIME-Version: 1.0 In-Reply-To: <5638EF6C.3080603@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OaRKWTmDNapU8GIdD0vTrI9nglhqPcvJN" Subject: Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: vsementsov@virtuozzo.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OaRKWTmDNapU8GIdD0vTrI9nglhqPcvJN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2015 10:31 AM, John Snow wrote: >=20 >=20 > On 11/03/2015 10:23 AM, Eric Blake wrote: >> On 10/23/2015 05:56 PM, John Snow wrote: >>> Add both transactional properties to the QMP transactional interface,= >>> and add the BlockJobTxn that we create as a result of the err-cancel >>> property to the BlkActionState structure. >>> >>> +# @actions: List of @TransactionAction; >>> +# information needed for the respective operations. >>> +# >>> +# @properties: Optional structure of additional options to control t= he >> >> Elsewhere, we've spelled it '#optional'; Marc-Andre has patches that >> rely on that spelling to turn it .json into documentation. >> >> But otherwise, looks good on first glance. >> >=20 > Do you mean: >=20 > "# @properties: #optional structure of "... ? Yes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OaRKWTmDNapU8GIdD0vTrI9nglhqPcvJN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWOPB0AAoJEKeha0olJ0NqCykIAJiBWv39XbmB+tFLEy4Wmzc3 iTE6sprVVSxgCa3kUbuX60eL1C5WxufLjWDNFXDo/5Rx4TFFIm8T7J+Zt2ScViiL Ir/kqd+H/cVdaFbbW9wODaFFNV3g+2lpprq9EOQlEPh4MOn3x9AeW8a8SumkEBcM UMxFKgYulzw1Kta7pMACNWEepgT2/b6R7MVGiGuwhPFC2EzefPWIT4TJx6+jx23N QmXoVZKPWr2vco5d9I0jVUOifwsm90srV9IbarvGXjZOyyQF9Ga5iw+khc+KZg+C zfwLthrMCGQ6LdYuLAHLMKSVIaHYY1s6Ks03gmNlRT77xiDa49TxqCmFWB386QI= =GNpk -----END PGP SIGNATURE----- --OaRKWTmDNapU8GIdD0vTrI9nglhqPcvJN--