qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] target-i386: Don't trigger "check" warnings by default in KVM mode
Date: Tue, 3 Nov 2015 18:49:08 +0100	[thread overview]
Message-ID: <5638F394.2050603@redhat.com> (raw)
In-Reply-To: <20151103174131.GC20436@thinpad.lan.raisama.net>



On 03/11/2015 18:41, Eduardo Habkost wrote:
> I just got a report from David that the lack of ABM on Sandy Bridge
> hosts will trigger the warning, too. I guess we don't want to require a
> Haswell CPU to run the default CPU model with KVM, so ABM would be
> disabled by default in KVM mode too.
> 
> We really should make the defaults different in TCG and KVM mode. The
> question is what to do about the TCG defaults in QEMU 2.5.
> 
> I propose we remove ABM and SSE4E from qemu64 in 2.5,

But if we do that for all machine types we break guest ABI for >=Haswell
on old machine types; if we do that for 2.5 only we get "-cpu check"
warnings on old machine types.

This is true even if we implement different defaults for KVM and TCG.
Should we disable "-cpu check" for old machine types (or do we already
do that)?  That would suck, but it would let us drop ABM and SSE4A from
the 2.4 machine type without much hassle.

> and implement a
> proper mechanism to have different KVM and TCG defaults after 2.5. We
> never pretended that qemu64 had all TCG-supported features enabled
> anyway: the last time the feature set of qemu64 was changed was in 2009
> (when we added ABM).

That's true.

Paolo

  reply	other threads:[~2015-11-03 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 19:00 [Qemu-devel] [PATCH 0/3] target-i386: Don't trigger "check" warnings by default in KVM mode Eduardo Habkost
2015-10-30 19:00 ` [Qemu-devel] [PATCH 1/3] target-i386: Add optional class name to kvm_default_props Eduardo Habkost
2015-10-30 19:00 ` [Qemu-devel] [PATCH 2/3] pc: Create pc_compat_2_4() function Eduardo Habkost
2015-10-30 19:01 ` [Qemu-devel] [PATCH 3/3] target-i386: Don't enable SSE4A by default with KVM Eduardo Habkost
2015-10-30 19:13 ` [Qemu-devel] [PATCH 0/3] target-i386: Don't trigger "check" warnings by default in KVM mode Eduardo Habkost
2015-11-02 11:37   ` Paolo Bonzini
2015-11-03 16:41     ` Eduardo Habkost
2015-11-03 17:21       ` Paolo Bonzini
2015-11-03 17:54         ` Eduardo Habkost
2015-11-03 17:41     ` Eduardo Habkost
2015-11-03 17:49       ` Paolo Bonzini [this message]
2015-11-03 17:56         ` Eduardo Habkost
2015-11-03 19:53           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5638F394.2050603@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).