From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging
Date: Tue, 3 Nov 2015 18:50:52 +0100 [thread overview]
Message-ID: <5638F3FC.8020902@redhat.com> (raw)
In-Reply-To: <5638F216.3080207@openvz.org>
On 03/11/2015 18:42, Denis V. Lunev wrote:
>
> There 2 small notes here:
> - there is small patch with 'all' alias for all tracepoints which
> could also be useful in the scope of this work:
> [PATCH v2 1/1] allow to enable all tracepoints via alias all
>
> - it would be great if patches from my log patchset will be merged.
> I'll port them tomorrow on top of this set (if will not work on
> findings in locking patchset)
> Switch from inline call to #define and QMP/QAPI logging seems
> really necessary. timestamp could be enabled or not but it is
> better to use unified approach for logging timestamps and
> tracing timestamps.
I think the "right" way would be to add tracepoints to the qmp_*
functions, or to make your logging a tracepoint. BTW, why are you not
logging QMP commands from the Virtuozzo management tool? That's what
libvirt is doing, you can find the JSON in qemu.log IIRC.
Paolo
next prev parent reply other threads:[~2015-11-03 17:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 20:44 [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 01/11] trace: fix documentation Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 02/11] trace: split trace_init_events out of trace_init_backends Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 03/11] trace: split trace_init_file " Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 05/11] trace: add "-trace enable=..." Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 06/11] trace: add "-trace help" Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 07/11] log: do not unnecessarily include qom/cpu.h Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 09/11] trace: convert stderr backend to log Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 10/11] trace: switch default backend to "log" Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN" Denis V. Lunev
2015-11-03 11:39 ` [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging Denis V. Lunev
2015-11-03 15:33 ` Stefan Hajnoczi
2015-11-03 17:10 ` Stefan Hajnoczi
2015-11-03 17:33 ` Paolo Bonzini
2015-11-03 17:42 ` Denis V. Lunev
2015-11-03 17:50 ` Paolo Bonzini [this message]
2015-11-03 18:03 ` Denis V. Lunev
2016-01-07 9:58 ` Stefan Hajnoczi
2016-01-07 10:35 ` Denis V. Lunev
2016-01-07 12:40 ` Denis V. Lunev
2016-01-07 14:08 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638F3FC.8020902@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).