From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZtgaU-0007Qi-PS
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:45:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZtgaQ-0006Q6-HC
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:45:42 -0500
Received: from relay.parallels.com ([195.214.232.42]:36023)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZtgaQ-0006PX-9N
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:45:38 -0500
References: <1446570199-29893-1-git-send-email-den@openvz.org>
	<871tc70vvf.fsf@blackfin.pond.sub.org>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <563900C5.3040606@openvz.org>
Date: Tue, 3 Nov 2015 21:45:25 +0300
MIME-Version: 1.0
In-Reply-To: <871tc70vvf.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via
 alias all
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Olga Krishtal <okrishtal@parallels.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 11/03/2015 09:40 PM, Markus Armbruster wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
>
>> From: Olga Krishtal <okrishtal@parallels.com>
>>
>> This will produce a lot of noise but could be usefull when we do this
>> for a shot perioud of time on customer side to examine unclear problem.
>>
>> Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> Changes from v1:
>> - proper mailing list targeted
>>
>>   trace/control.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/trace/control.c b/trace/control.c
>> index 9a1e381..75085f6 100644
>> --- a/trace/control.c
>> +++ b/trace/control.c
>> @@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
>>   
>>   static bool pattern_glob(const char *pat, const char *ev)
>>   {
>> +    if (!(g_strcmp0(pat, "all"))) {
>> +        return true;
>> +    }
>>       while (*pat != '\0' && *ev != '\0') {
>>           if (*pat == *ev) {
>>               pat++;
> What's wrong with '*'?
according to our tests plain '*' is not accepted.
It accepts 'bdrv*' or 'qcow2*' but not single '*'.
may be we are doing something wrong.

Den