* [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all
@ 2015-11-03 17:03 Denis V. Lunev
2015-11-03 18:40 ` Markus Armbruster
0 siblings, 1 reply; 4+ messages in thread
From: Denis V. Lunev @ 2015-11-03 17:03 UTC (permalink / raw)
Cc: Olga Krishtal, Paolo Bonzini, qemu-devel, Stefan Hajnoczi,
Denis V. Lunev
From: Olga Krishtal <okrishtal@parallels.com>
This will produce a lot of noise but could be usefull when we do this
for a shot perioud of time on customer side to examine unclear problem.
Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
Changes from v1:
- proper mailing list targeted
trace/control.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/trace/control.c b/trace/control.c
index 9a1e381..75085f6 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
static bool pattern_glob(const char *pat, const char *ev)
{
+ if (!(g_strcmp0(pat, "all"))) {
+ return true;
+ }
while (*pat != '\0' && *ev != '\0') {
if (*pat == *ev) {
pat++;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all
2015-11-03 17:03 [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all Denis V. Lunev
@ 2015-11-03 18:40 ` Markus Armbruster
2015-11-03 18:45 ` Denis V. Lunev
2015-11-03 19:02 ` Denis V. Lunev
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2015-11-03 18:40 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: Olga Krishtal, qemu-devel, Stefan Hajnoczi, Paolo Bonzini
"Denis V. Lunev" <den@openvz.org> writes:
> From: Olga Krishtal <okrishtal@parallels.com>
>
> This will produce a lot of noise but could be usefull when we do this
> for a shot perioud of time on customer side to examine unclear problem.
>
> Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Changes from v1:
> - proper mailing list targeted
>
> trace/control.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/trace/control.c b/trace/control.c
> index 9a1e381..75085f6 100644
> --- a/trace/control.c
> +++ b/trace/control.c
> @@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
>
> static bool pattern_glob(const char *pat, const char *ev)
> {
> + if (!(g_strcmp0(pat, "all"))) {
> + return true;
> + }
> while (*pat != '\0' && *ev != '\0') {
> if (*pat == *ev) {
> pat++;
What's wrong with '*'?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all
2015-11-03 18:40 ` Markus Armbruster
@ 2015-11-03 18:45 ` Denis V. Lunev
2015-11-03 19:02 ` Denis V. Lunev
1 sibling, 0 replies; 4+ messages in thread
From: Denis V. Lunev @ 2015-11-03 18:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Olga Krishtal, qemu-devel, Stefan Hajnoczi, Paolo Bonzini
On 11/03/2015 09:40 PM, Markus Armbruster wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
>
>> From: Olga Krishtal <okrishtal@parallels.com>
>>
>> This will produce a lot of noise but could be usefull when we do this
>> for a shot perioud of time on customer side to examine unclear problem.
>>
>> Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> Changes from v1:
>> - proper mailing list targeted
>>
>> trace/control.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/trace/control.c b/trace/control.c
>> index 9a1e381..75085f6 100644
>> --- a/trace/control.c
>> +++ b/trace/control.c
>> @@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
>>
>> static bool pattern_glob(const char *pat, const char *ev)
>> {
>> + if (!(g_strcmp0(pat, "all"))) {
>> + return true;
>> + }
>> while (*pat != '\0' && *ev != '\0') {
>> if (*pat == *ev) {
>> pat++;
> What's wrong with '*'?
according to our tests plain '*' is not accepted.
It accepts 'bdrv*' or 'qcow2*' but not single '*'.
may be we are doing something wrong.
Den
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all
2015-11-03 18:40 ` Markus Armbruster
2015-11-03 18:45 ` Denis V. Lunev
@ 2015-11-03 19:02 ` Denis V. Lunev
1 sibling, 0 replies; 4+ messages in thread
From: Denis V. Lunev @ 2015-11-03 19:02 UTC (permalink / raw)
To: Markus Armbruster
Cc: Olga Krishtal, qemu-devel, Stefan Hajnoczi, Paolo Bonzini
On 11/03/2015 09:40 PM, Markus Armbruster wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
>
>> From: Olga Krishtal <okrishtal@parallels.com>
>>
>> This will produce a lot of noise but could be usefull when we do this
>> for a shot perioud of time on customer side to examine unclear problem.
>>
>> Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> Changes from v1:
>> - proper mailing list targeted
>>
>> trace/control.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/trace/control.c b/trace/control.c
>> index 9a1e381..75085f6 100644
>> --- a/trace/control.c
>> +++ b/trace/control.c
>> @@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
>>
>> static bool pattern_glob(const char *pat, const char *ev)
>> {
>> + if (!(g_strcmp0(pat, "all"))) {
>> + return true;
>> + }
>> while (*pat != '\0' && *ev != '\0') {
>> if (*pat == *ev) {
>> pat++;
> What's wrong with '*'?
you are right. I have done things wrong. This patch is not needed at all.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-03 19:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 17:03 [Qemu-devel] [PATCH v2 1/1] allow to enable all tracepoints via alias all Denis V. Lunev
2015-11-03 18:40 ` Markus Armbruster
2015-11-03 18:45 ` Denis V. Lunev
2015-11-03 19:02 ` Denis V. Lunev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).