From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztog5-0008Fz-Nl for qemu-devel@nongnu.org; Tue, 03 Nov 2015 22:24:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztog0-0006Jq-Mp for qemu-devel@nongnu.org; Tue, 03 Nov 2015 22:24:01 -0500 Received: from mga09.intel.com ([134.134.136.24]:15783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztog0-0006Jd-H0 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 22:23:56 -0500 References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> <1446455617-129562-12-git-send-email-guangrong.xiao@linux.intel.com> <20151103232151.GH4180@thinpad.lan.raisama.net> From: Xiao Guangrong Message-ID: <563978B5.5070803@linux.intel.com> Date: Wed, 4 Nov 2015 11:17:09 +0800 MIME-Version: 1.0 In-Reply-To: <20151103232151.GH4180@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 11/35] util: introduce qemu_file_getlength() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: vsementsov@virtuozzo.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/04/2015 07:21 AM, Eduardo Habkost wrote: > On Mon, Nov 02, 2015 at 05:13:13PM +0800, Xiao Guangrong wrote: > [...] >> +size_t qemu_file_getlength(const char *file, Error **errp) >> +{ >> + int64_t size; > [...] >> + return size; > > Can you guarantee that SIZE_MAX >= INT64_MAX on all platforms supported > by QEMU? > Actually, this function is abstracted from the common function, raw_getlength(), in raw-posix.c whose return value is int64_t. And i think int64_t is large enough for block devices.