From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu0ii-0001T6-HY for qemu-devel@nongnu.org; Wed, 04 Nov 2015 11:15:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zu0ih-0001bh-9y for qemu-devel@nongnu.org; Wed, 04 Nov 2015 11:15:32 -0500 References: From: Max Reitz Message-ID: <563A2F0C.9070209@redhat.com> Date: Wed, 4 Nov 2015 17:15:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HhLE5XmLgVQNG4T7I47FRh43iUqN8Jx9t" Subject: Re: [Qemu-devel] [PATCH v4 0/4] Add 'x-blockdev-del' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HhLE5XmLgVQNG4T7I47FRh43iUqN8Jx9t Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 02.11.2015 15:51, Alberto Garcia wrote: > This version has only documentation and test fixes. >=20 > Most are cosmetic changes, but there were two missing wait_ready() and > wait_until_completed() calls that could break one of the tests. >=20 > Regards, >=20 > Berto >=20 > v4: > - patch 3: s/being used/in use/ [Max] > - patch 3: add 'blockdev-add' command to the 'x-blockdev-del' example > in qmp-commands.hx [Max] > - patch 4: clarify that the BlkDebug and BlkVerify are not meant to be > real use cases of those drivers, but only to test the sanity checks > of 'x-blockdev-del' [Max] > - patch 4: fix addBlockDriverStateOverlay() documentation [Max] > - patch 4: add missing wait_ready() and wait_until_completed() calls >=20 > v3: https://lists.gnu.org/archive/html/qemu-block/2015-10/msg00854.html= > - Remove the extra references added in v2 to the mirror and backup > jobs, and use op blockers instead (for the mirror case only). >=20 > v2: https://lists.gnu.org/archive/html/qemu-block/2015-10/msg00828.html= > - Rename it as 'x-blockdev-del' and label it as experimental. > - Use two parameters instead of just one. If you try to delete a BDS, > it must not be attached to any backend. > - New test cases. > - Hold extra references during the mirror and backup block jobs. >=20 > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02999.html= > - Initial implementation >=20 > Alberto Garcia (4): > mirror: block all operations on the target image during the job > block: Add blk_get_refcnt() > block: Add 'x-blockdev-del' QMP command > iotests: Add tests for the x-blockdev-del command >=20 > block/block-backend.c | 5 + > block/mirror.c | 4 + > blockdev.c | 66 +++++++ > include/sysemu/block-backend.h | 1 + > qapi/block-core.json | 32 +++- > qmp-commands.hx | 61 +++++- > tests/qemu-iotests/139 | 414 +++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/139.out | 5 + > tests/qemu-iotests/group | 1 + > 9 files changed, 585 insertions(+), 4 deletions(-) > create mode 100644 tests/qemu-iotests/139 > create mode 100644 tests/qemu-iotests/139.out Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block Max --HhLE5XmLgVQNG4T7I47FRh43iUqN8Jx9t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWOi8NAAoJEDuxQgLoOKyt+uUH+wagtQfegGCOX6bDAsdHlEKs /DnztChlpDzfV0zf4OJpCr4+JjUJYjrbFqmWzHd92AfgWycw1PzM7lVwnaLbq2Nz qTCZxXgfpjzcxiU/FHExmAUHJSZMhWGXvoyv8asY25ZsjkXa8jhXFoUFVpMzGyTq JZnJMQuCopjvGl3wxFDdpjnawiznJMGGhwG9JRtw0LwV95vuxzN8c242mIyjWFOB jalWr5TcRH4IQ0NXUvgrPxTQTZict2KNpMA/6eM2erOUakOZJod9L6IxiyRw4QDz EivO/nDZztHTkgwsNifoPSgAkOHTdDcX5PseWMpgveIjmdIQtpgCbAGyAeUaIsE= =f3Yt -----END PGP SIGNATURE----- --HhLE5XmLgVQNG4T7I47FRh43iUqN8Jx9t--