From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu75m-0002Xp-4E for qemu-devel@nongnu.org; Wed, 04 Nov 2015 18:03:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zu75h-0000SJ-6M for qemu-devel@nongnu.org; Wed, 04 Nov 2015 18:03:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu75g-0000SE-V5 for qemu-devel@nongnu.org; Wed, 04 Nov 2015 18:03:41 -0500 References: <1446618049-13596-1-git-send-email-eblake@redhat.com> <1446618049-13596-18-git-send-email-eblake@redhat.com> <87ziytnalj.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <563A8EC3.6020402@redhat.com> Date: Wed, 4 Nov 2015 16:03:31 -0700 MIME-Version: 1.0 In-Reply-To: <87ziytnalj.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n8hMFKbG7AsjQHt8JOasN6A1MObwBupNO" Subject: Re: [Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n8hMFKbG7AsjQHt8JOasN6A1MObwBupNO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/04/2015 06:43 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> From: Markus Armbruster >> >> QAPISchemaObjectTypeVariants.check() parameter members is no >> longer used, drop it. >> >> Signed-off-by: Markus Armbruster >> Message-Id: <1446559499-26984-3-git-send-email-armbru@redhat.com> >> [Variant.check(seen) is used after all, so reword and reduce scope >> of this patch; rearrange later in the series] >=20 > Don't you need to update the subject? My "previous commit" was "qapi: > Simplify QAPISchemaObjectTypeMember.check()", while yours is "qapi: > Eliminate QAPISchemaObjectType.check() variable members". >=20 > Not sure what moving my two patches apart buys you :) I'm not quite sure either. [Can I blame late-night coding?] For reference, this was your 3/7 patch. I was trying to get to the point of my 'qapi: Check for qapi collisions of flat union branches' (ended up as 19/27) as soon as possible after my tweaks to your 'qapi: Drop obsolete tag value collision assertions' (your 1/7), so that there was less of a gap where avoiding churn on passing vseen(dict) to Variant.check() looked like an unused variable. In my first attempt, I tried floating my patch right after yours. But I quickly discovered that my patch worked better if I built it on top of your 'qapi: Factor out QAPISchemaObjectTypeMember.check_clash()' (your 6/7), which in turn depended on several of your other patches. So the end result of what I posted happens to be whatever order worked for all my cherry-picking, and I still ended up having to tweak both your 1/7 and 3/7 after all. For v10, I may just go back to the order that you first supplied patches in (if for no other reason than to make your commit message more accurate about being a cleanup of the previous patch, with the meaning that you had given it). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --n8hMFKbG7AsjQHt8JOasN6A1MObwBupNO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWOo7DAAoJEKeha0olJ0NqXWIIAIFefniUBxZSusprU1jKKmrq 7lUYkHhAzTIU+QM4zhBTJ4bLOl8qdpcYOln7cg0R7Tur1WgCjAtfzZ7qBwMh8jhe JBcAr9v0uTiwb3HVNUAg48mHYqlnajB6j/ncJCcoMehz5RDYPBKskAQFhSlgfSyp JyQogbEUr7aXMlQv186EFURaAjkQydrCsQ1Ys14UnuDFp9c3h/n7lbzDd/9lCVbQ Y1uYCypNfTgrMp6BZVFFQRXNyDwn+2hBzi8fVxDHBN8ZlHCGe2eGuOJixbdrbKd3 kgESpFITQqsnkonJtCRyrJDHituqKQJPxcQUxrK/35SckaUpQVO1S0zQsKAfN64= =Flps -----END PGP SIGNATURE----- --n8hMFKbG7AsjQHt8JOasN6A1MObwBupNO--