From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuFVH-0004tf-Cx for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:02:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuFVD-0006DZ-Iz for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:02:39 -0500 Received: from relay.parallels.com ([195.214.232.42]:56716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuFVD-0006DM-C7 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:02:35 -0500 References: <1446657582-21619-1-git-send-email-den@openvz.org> <1446657582-21619-3-git-send-email-den@openvz.org> <20151105085558.31d3a8f3@bahia.local> From: "Denis V. Lunev" Message-ID: <563B0D0D.5070806@openvz.org> Date: Thu, 5 Nov 2015 11:02:21 +0300 MIME-Version: 1.0 In-Reply-To: <20151105085558.31d3a8f3@bahia.local> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela On 11/05/2015 10:55 AM, Greg Kurz wrote: > On Wed, 4 Nov 2015 20:19:33 +0300 > "Denis V. Lunev" wrote: > >> this will make code better in the next patch >> > This changelog is not very useful. IMHO this calls for squashing this patch > into the next one: then we clearly see how the return value is used and why > the code is better. is it principal to get the series merged? In general I have a strong opinion that non-functional changes should be separated from functional ones. This makes review faster and allows to concentrate on things where we can have mistakes. Den