From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZuGiu-0002Xt-4q
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:20:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZuGip-00042n-72
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:20:48 -0500
Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZuGio-00042j-V7
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:20:43 -0500
Received: by wmeg8 with SMTP id g8so7547892wme.1
	for <qemu-devel@nongnu.org>; Thu, 05 Nov 2015 01:20:42 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1446473134-4330-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA97rV3sZTZ085uLKnTc5_hQeJVrnN0CHt97ryzxk5iwGA@mail.gmail.com>
	<563777D5.6050000@redhat.com>
	<CAFEAcA-e23HiTvxji+y5LetLY2S66MGPEdfok4vLjJFou_6FKw@mail.gmail.com>
	<5639DA14.3020507@twiddle.net> <5639E1C2.80902@redhat.com>
	<5639E691.4050203@twiddle.net> <563A968D.705@ilande.co.uk>
	<563B1D91.5010701@redhat.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <563B1F65.5000603@twiddle.net>
Date: Thu, 5 Nov 2015 10:20:37 +0100
MIME-Version: 1.0
In-Reply-To: <563B1D91.5010701@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in
	fpackfix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On 11/05/2015 10:12 AM, Paolo Bonzini wrote:
> 	/* Ugly code */
> 	int64_t scaled = (uint64_t)(int64_t)src << scale;

You mean

   int64_t scaled = (int64_t)((uint64_t)src << scale);


r~