From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuJ2r-0001rG-5J for qemu-devel@nongnu.org; Thu, 05 Nov 2015 06:49:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuJ2m-00025V-69 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 06:49:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuJ2m-00025E-0d for qemu-devel@nongnu.org; Thu, 05 Nov 2015 06:49:28 -0500 References: From: Paolo Bonzini Message-ID: <563B4237.6050709@redhat.com> Date: Thu, 5 Nov 2015 12:49:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers , Gerd Hoffmann On 05/11/2015 12:42, Peter Maydell wrote: > I tried to do a linux headers update against kvm/next (commit > 197a4f4b063e4) with update-linux-headers.sh, but the result gives > a virtio-gpu that doesn't compile: >=20 > make: Entering directory > `/home/petmay01/linaro/qemu-from-laptop/qemu/build/all-debug' > CC aarch64-softmmu/hw/display/virtio-gpu.o > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c: > In function =E2=80=98virtio_gpu_get_features=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:149= :27: > error: =E2=80=98VIRTIO_GPU_FEATURE_VIRGL=E2=80=99 undeclared (first use= in this > function) > features |=3D (1 << VIRTIO_GPU_FEATURE_VIRGL); > ^ > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:149= :27: > note: each undeclared identifier is reported only once for each > function it appears in > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c: > In function =E2=80=98virtio_gpu_set_features=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:156= :41: > error: =E2=80=98VIRTIO_GPU_FEATURE_VIRGL=E2=80=99 undeclared (first use= in this > function) > static const uint32_t virgl =3D (1 << VIRTIO_GPU_FEATURE_VIRGL); > ^ > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c: > In function =E2=80=98virtio_gpu_device_realize=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:914= :25: > error: =E2=80=98struct virtio_gpu_config=E2=80=99 has no member named =E2= =80=98num_capsets=E2=80=99 > g->virtio_config.num_capsets =3D 1; > ^ > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c: > At top level: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:103= 5:46: > error: invalid application of =E2=80=98sizeof=E2=80=99 to incomplete ty= pe =E2=80=98struct > virtio_gpu_transfer_host_3d=E2=80=99 > QEMU_BUILD_BUG_ON(sizeof(struct virtio_gpu_transfer_host_3d) !=3D= 72); > ^ >=20 > etc, because all the virtio_gpu definitions disappear from > include/standard-headers/linux/virtio_gpu.h. >=20 > What's happening here? My guess: these will get into Linus's tree in a few days, and the update was done on a maintainer tree. Paolo