From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLnx-0005t6-FS for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuLnp-0005Ja-KX for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:46:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLnp-0005JW-FD for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:46:13 -0500 References: <911665eb3158159da19e7bf1c931f6311a246be9.1446714761.git.v.maffione@gmail.com> <87wptwvbvy.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <563B6BAD.4030202@redhat.com> Date: Thu, 5 Nov 2015 07:46:05 -0700 MIME-Version: 1.0 In-Reply-To: <87wptwvbvy.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xJDRQmQE925VaxDao8o87CRqWfNTcT4r9" Subject: Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Vincenzo Maffione Cc: jasowang@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xJDRQmQE925VaxDao8o87CRqWfNTcT4r9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/05/2015 06:01 AM, Markus Armbruster wrote: > Vincenzo Maffione writes: >=20 >> Reorganization of struct NetClientOptions caused a compilation failure= >> of the netmap backend. This patch fixes the issue by properly accessin= g the >> union field. >> >> Signed-off-by: Vincenzo Maffione >> --- >> net/netmap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/netmap.c b/net/netmap.c >> index 508b829..4197a9c 100644 >> --- a/net/netmap.c >> +++ b/net/netmap.c >> @@ -439,7 +439,7 @@ int net_init_netmap(const NetClientOptions *opts, >> const char *name, NetClientState *peer, Error **e= rrp) >> { >> /* FIXME error_setg(errp, ...) on failure */ >> - const NetdevNetmapOptions *netmap_opts =3D opts->netmap; >> + const NetdevNetmapOptions *netmap_opts =3D opts->u.netmap; >> NetClientState *nc; >> NetmapPriv me; >> NetmapState *s; >=20 > Broken in commit e4ba22b. Recommend to point to that in the commit > message. Thanks for cleaning up the mess we made there! My fault for not compiling netmap code. Does it need specific configure options? >=20 > Reviewed-by: Markus Armbruster >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xJDRQmQE925VaxDao8o87CRqWfNTcT4r9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWO2utAAoJEKeha0olJ0NqWl4H/2RoU7cdp/3WUNXhsIu8TIIG 3s/cBeIUML/rGs80RRl2yjBgCGf0cUJvz4FjnYfF/iWZ2gRQ/yThHSLrq2AVs1KQ Mqlmk5KksKr+SmG5RSTZtimLdMl7oUJoUYoDiptYWeK0peidDjdbEff4SAOfMKH6 SgpkHLJifKB3UixMTK91M7aOfpZ2vPfb4b9WoV3b0cKyq0nEGa5fpOMgs2yMh0vN /ftm31EYOZJAazpc6w/mKGJHYbAWwkBhXC8TwjFRGN1RiKa/S/EjcYG3rtX/SKXp WEivIoPbVjtR9RdCD34O7vnw6tEkEgCUevTjIQINod8Nnm3FlZr++/H8BHWQI5I= =jQWq -----END PGP SIGNATURE----- --xJDRQmQE925VaxDao8o87CRqWfNTcT4r9--