From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLuQ-00023u-RC for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:53:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuLuQ-000838-0f for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:53:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLuP-000832-RA for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:53:01 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-2-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <563B6D4B.1090107@redhat.com> Date: Thu, 5 Nov 2015 07:52:59 -0700 MIME-Version: 1.0 In-Reply-To: <1446551816-15768-2-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P424uEUAIVoPk4u72jQqVOuH1CUaCd9VV" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 01/38] configure: Add parameter for configure to enable/disable COLO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P424uEUAIVoPk4u72jQqVOuH1CUaCd9VV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2015 04:56 AM, zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > COLO support is off by default. Off by default risks bit-rot for people not building it; it's generally best to default to off only if the feature requires dragging in extra libraries or similar build items not likely to be present in all development environments (and even then, auto-probing for required prerequisites is nicer than hard-coding off). Would on-by-default be a saner choice, or would that drag in too many extra dependencies for building? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --P424uEUAIVoPk4u72jQqVOuH1CUaCd9VV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWO21LAAoJEKeha0olJ0NqQrsH/29+bZz4NcsNlz4GD445XJTw Bks4e46rnfGHlHro1Bpvu1sgTfCkKsjrPMLJL/DjMrx9ep7DxBniRpPxmhKxEH8B I0zAso6G5HUyJ5G68715dJLI/nnBEhvGw6OWQjqF7n1jHtu4VdghNBarV2fP0vXU Ma0Liq4AkWY1488+4dE0V+ZZnQdcwDekisOEzDsPspb+3FXnKkRJWEuqj8GIJB4k RwExr8p57+a4buIHvXeyKi1c6KzxxiGckDW1dffzYqPkL3TsMqZuLhhIqYZLO/sj hh6/dVLb51zfebwmsI7CPJIGX/L8s+PbuxJgOq4sgDVgjx9Nee0ulpq4CFvHQzk= =7hCT -----END PGP SIGNATURE----- --P424uEUAIVoPk4u72jQqVOuH1CUaCd9VV--