From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuM5k-0002eu-B2 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 10:04:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuM5g-0002iR-9i for qemu-devel@nongnu.org; Thu, 05 Nov 2015 10:04:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuM5g-0002i0-4e for qemu-devel@nongnu.org; Thu, 05 Nov 2015 10:04:40 -0500 References: <1446618049-13596-1-git-send-email-eblake@redhat.com> <1446618049-13596-5-git-send-email-eblake@redhat.com> <87mvuutaxo.fsf@blackfin.pond.sub.org> <563A7328.2050807@redhat.com> <874mh07ugg.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <563B7006.907@redhat.com> Date: Thu, 5 Nov 2015 08:04:38 -0700 MIME-Version: 1.0 In-Reply-To: <874mh07ugg.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hv8XV0aDWSqVtmwGm6wbcIKF6MwGraGeG" Subject: Re: [Qemu-devel] [PATCH v9 04/27] qapi: Simplify error testing in test-qmp-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hv8XV0aDWSqVtmwGm6wbcIKF6MwGraGeG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/05/2015 12:53 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 11/04/2015 01:40 AM, Markus Armbruster wrote: >> >>> >>>> By moving err into data, we can let test teardown take care >>>> of cleaning up any collected error; it also gives us fewer >>>> lines of code between repeated tests where init runs teardown >>>> on our behalf. >>> >>> This part isn't as obvious. >>> >>> Having two parts of differing obviousness indicates patch splitting >>> could make sense. Especially when the parts are large and mechanical= , >>> because reviewing large mechanical changes is much easier when there'= s >>> just one kind of it. >> >> Will split. > Perhaps we want something like >=20 > * Expect an error, abort() if there is none: > * error_free_or_abort(&err); > * This frees the error object and clears err. Convenient for tests. Don't know if we'd want that directly in error.h, or just in the affected tests, but I like the idea. All the more reason for me to split the patch into expected error vs. expected no error cases. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hv8XV0aDWSqVtmwGm6wbcIKF6MwGraGeG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWO3AGAAoJEKeha0olJ0Nqt1AIAI+WlSG8NAzndKfvn9+Rrm5K W7swsls01+4WfXGfW/M40zmNLobPFfBw/9XyMHqXZSqeZMPuHDbfLem8DFfAqU5X IV/YGw575iBrjMDeFfPS2pnkb5zjMLJPqPaR4cNonP7h196g/2Era7cYEZ1ons31 lLHciPXQS386bvYS5J8hQtCh+SeuBE49uvbzKlDGCDCJ/Nl/rkZ/Kr9sPZ26u5iS YkqSBLrEIXN7ye0CXovlVS4zthhoEExjiPXar7633qDKRCi321JF/g/EqbnQ7I12 dL+TgGsJat054BnZvjr1gv8BG9p5su9iZsMQTyJhMGUxKp0U5DrWp9M0IG6ifJI= =/njz -----END PGP SIGNATURE----- --hv8XV0aDWSqVtmwGm6wbcIKF6MwGraGeG--