From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuO6g-0000yh-L2 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 12:13:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuO6f-0002pd-NE for qemu-devel@nongnu.org; Thu, 05 Nov 2015 12:13:50 -0500 References: <1446743477-21579-1-git-send-email-wei@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <563B8E48.8020407@suse.de> Date: Thu, 5 Nov 2015 18:13:44 +0100 MIME-Version: 1.0 In-Reply-To: <1446743477-21579-1-git-send-email-wei@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang , qemu-arm@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org Am 05.11.2015 um 18:11 schrieb Wei Huang: > arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu. > Such mixed-uses make source code inconsistent. This patch removes > NUM_CPU(s), which was defined for MPCore tweak long ago, and instead > favors s->num_cpu. The source is more consistent after this tweak. >=20 > Signed-off-by: Wei Huang > --- > hw/intc/arm_gic.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) I don't mind either way, and it'll go through Peter's queue I guess, Reviewed-by: Andreas F=E4rber Cheers, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)