From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZujGR-0003Yf-MR for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:49:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZujGN-0006dc-CJ for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:49:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZujGN-0006dR-77 for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:49:15 -0500 References: <1446791754-23823-1-git-send-email-eblake@redhat.com> <1446791754-23823-6-git-send-email-eblake@redhat.com> <87bnb717ch.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <563CCBF5.6040405@redhat.com> Date: Fri, 6 Nov 2015 08:49:09 -0700 MIME-Version: 1.0 In-Reply-To: <87bnb717ch.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q6koWHAKwO955NnblHEwU50hdMarvIXRM" Subject: Re: [Qemu-devel] [PATCH v10 05/30] qapi: Plug leaks in test-qmp-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q6koWHAKwO955NnblHEwU50hdMarvIXRM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/06/2015 08:21 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Make valgrind happy with the current state of the tests, so that >> it is easier to see if future patches introduce new memory problems >> without being drowned in noise. Many of the leaks were due to >> calling a second init without tearing down the data from an earlier >> visit. But since teardown is already idempotent, and we already >> register teardown as part of input_visitor_test_add(), it is nicer >> to just make init() safe to call multiple times than it is to have >> to make all tests call teardown. >> >> @@ -191,6 +193,7 @@ static void test_validate_fail_struct(TestInputVis= itorData *data, >> >> visit_type_TestStruct(v, &p, NULL, &err); >> g_assert(err); >> + error_free(err); >=20 > v9 had /* FIXME: visitor should not allocate p when returning error */ > here. Did you drop it intentionally? >=20 Yes, I dropped it intentionally. > If you put it back, please mention it in the commit message. Rather, I decided that it was sufficient to just fix the bug later (patch already queued, but not posted), and minimize the churn (no need to mark things up just to pull down the markings later): http://repo.or.cz/qemu/ericb.git/commitdiff/ac584b53a --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --q6koWHAKwO955NnblHEwU50hdMarvIXRM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWPMv1AAoJEKeha0olJ0Nqjq8IAKtq/2VFqprrsCycx3j+GzVw aSxAfK7rdl/nnO6n5iJp0n6qq7isAou3zk1xFd0MXT77d7dTWEwkzDmKCiDCvYcb mleAwQDwg7dHNcIbCfgQyS/ejYTZFWB98IDNDl86LfNSIK3/L1Suq2EO4NNSN86Y 9qJb4MIkE01ZQQ6SzebZCHE4JgoRjPaRxQlSpEe2oosrvESvChJgOqXAQgDqY6j6 aBvd5kAUfwOU71C5MI321MACS2dQw/F8nX3ycm+UtZkz7pInux1Ceu3LM3FB1/sA +DswzVZPBij0ZEHuTX8WmZ61g7o/sCTmH+lbemL4QbB9/NK90afnvGPRzzNlC2M= =HUcD -----END PGP SIGNATURE----- --q6koWHAKwO955NnblHEwU50hdMarvIXRM--