Re: [Qemu-devel] [PATCH v10 00/30] qapi member collision (post-introspection cleanups, subset C')

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

On 11/06/2015 09:03 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> No pending prerequisites; based on qemu.git master
>>
>> Also available as a tag at this location:
>> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv9c

Make that the qapi-cleanupv10c label.

>>
>> and will soon be part of my branch with the rest of the v5 series, at:
>> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
>>
>> v10 notes:
>> Split several patches, redo the middle patches from Markus to be
>> back in the order they were first posted, some fallout change to
>> my patches due to the nicer pattern of minimizing conditionals
>> inside .check(), by instead calling .check_clash() as needed.
>> Change data->err magic in tests to instead use a new helper
>> error_free_or_abort(). Add a patch that would prevent qapi
>> case-insensitive clashes.
>>
>> I am redoing my subset boundaries slightly: patches 23-27 of
>> v9 (updating the alternate layout) will be delayed to subset D,
>> and 2 other patches previously posted in subset D are now here
>> (turning qapi clash checking into actual error messages), so
>> the subject line of this cover letter is slightly different.
>>
>> Hopefully, we are converging on something that will be ready
>> for a pull request, especially for the earlier patches of this
>> subset.
> 
> I guess you mean PATCH 01-12.  I had a few questions, but the most
> likely outcome seems to be minor touchups I could apply in my tree.
> 
> I'm okay with trying to get more patches in, but let's get these out of
> the way meanwhile.

Yes, 01-12 seems like a good first set, if you want to make those
touchups (I've supplied some potential text improvements in reply to
some of your comments); I'm happy, as always, to take a peek over your
staging repo to double check what you are prepping for the pull request.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]