qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage
Date: Fri, 6 Nov 2015 14:01:36 -0500	[thread overview]
Message-ID: <563CF910.8070908@redhat.com> (raw)
In-Reply-To: <20151106094605.GC4071@noname.redhat.com>



On 11/06/2015 04:46 AM, Kevin Wolf wrote:
> Am 06.11.2015 um 00:53 hat John Snow geschrieben:
>> cvtnum returns an int64_t, not an int, so correct the lvalue types
>> wherever it is used. While we're at it, make the error messages more
>> meaningful and hopefully less confusing.
>>
>> v4:
>>  - Now missing ALL sweaters
>>
>> v3:
>>  - pulled a lot of loose yarn, now missing my sweater
>>    (Updated patch 1 even further, reported-by Kevin)
>>
>> v2:
>>  - Squashed NSIG error-checking from patch 3 into patch 1
>>  - Reported-by credits for Max and Reviewed-by from Eric added
> 
> Thanks, applied to the block branch. (Should we mention in the changelog
> that qemu 2.5 contains some of your sweaters?)
> 
> Kevin
> 

If you want to destroy my sweater, NACK this patch as I walk away (as I
walk away)

--js

      reply	other threads:[~2015-11-06 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 23:53 [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage John Snow
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 1/3] qemu-io: fix cvtnum lval types John Snow
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 2/3] qemu-io: Check for trailing chars John Snow
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 3/3] qemu-io: Correct error messages John Snow
2015-11-06  9:46 ` [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage Kevin Wolf
2015-11-06 19:01   ` John Snow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563CF910.8070908@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).