From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZumGd-0003K4-0R for qemu-devel@nongnu.org; Fri, 06 Nov 2015 14:01:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZumGc-0004fo-A1 for qemu-devel@nongnu.org; Fri, 06 Nov 2015 14:01:42 -0500 References: <1446767584-13132-1-git-send-email-jsnow@redhat.com> <20151106094605.GC4071@noname.redhat.com> From: John Snow Message-ID: <563CF910.8070908@redhat.com> Date: Fri, 6 Nov 2015 14:01:36 -0500 MIME-Version: 1.0 In-Reply-To: <20151106094605.GC4071@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com On 11/06/2015 04:46 AM, Kevin Wolf wrote: > Am 06.11.2015 um 00:53 hat John Snow geschrieben: >> cvtnum returns an int64_t, not an int, so correct the lvalue types >> wherever it is used. While we're at it, make the error messages more >> meaningful and hopefully less confusing. >> >> v4: >> - Now missing ALL sweaters >> >> v3: >> - pulled a lot of loose yarn, now missing my sweater >> (Updated patch 1 even further, reported-by Kevin) >> >> v2: >> - Squashed NSIG error-checking from patch 3 into patch 1 >> - Reported-by credits for Max and Reviewed-by from Eric added > > Thanks, applied to the block branch. (Should we mention in the changelog > that qemu 2.5 contains some of your sweaters?) > > Kevin > If you want to destroy my sweater, NACK this patch as I walk away (as I walk away) --js