From: Eric Blake <eblake@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-block@nongnu.org, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, ashijeetacharya@gmail.com,
paul.durrant@citrix.com
Subject: Re: [PATCH 1/3] Use &error_abort instead of separate assert()
Date: Fri, 13 Mar 2020 12:57:43 -0500 [thread overview]
Message-ID: <563f6769-74f4-f532-0e76-fe5875742ee1@redhat.com> (raw)
In-Reply-To: <20200313173745.2cwlwbkt4fc7nmpc@mozz.bu.edu>
On 3/13/20 12:37 PM, Alexander Bulekov wrote:
> On 200313 1805, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>
>> index 1a99277d60..aa9eee6ebf 100644
>> --- a/tests/qtest/fuzz/qos_fuzz.c
>> +++ b/tests/qtest/fuzz/qos_fuzz.c
>> @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
>> QList *lst;
>> Error *err = NULL;
> Can this err declaration be removed? Don't think it's used anywhere
> else.
Correct, it is not. With that additional line gone,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-13 17:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 17:05 [PATCH 0/3] Minor error handling cleanups Markus Armbruster
2020-03-13 17:05 ` [PATCH 1/3] Use &error_abort instead of separate assert() Markus Armbruster
2020-03-13 17:37 ` Alexander Bulekov
2020-03-13 17:57 ` Eric Blake [this message]
2020-03-14 4:58 ` Markus Armbruster
2020-03-17 12:21 ` Vladimir Sementsov-Ogievskiy
2020-03-13 17:05 ` [PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two Markus Armbruster
2020-03-13 17:58 ` Eric Blake
2020-03-17 12:27 ` Vladimir Sementsov-Ogievskiy
2020-03-13 17:05 ` [PATCH 3/3] xen-block: " Markus Armbruster
2020-03-13 18:01 ` Eric Blake
2020-03-13 19:48 ` Philippe Mathieu-Daudé
2020-03-17 12:32 ` Vladimir Sementsov-Ogievskiy
2020-03-17 19:03 ` Markus Armbruster
2020-03-17 20:04 ` Vladimir Sementsov-Ogievskiy
2020-03-13 17:26 ` [PATCH 0/3] Minor error handling cleanups Peter Maydell
2020-03-17 12:57 ` [PATCH v10 4/3] hw/sd/ssi-sd: fix error handling in ssi_sd_realize Vladimir Sementsov-Ogievskiy
2020-03-17 14:13 ` Philippe Mathieu-Daudé
2020-03-17 15:13 ` Markus Armbruster
2020-03-17 15:39 ` Markus Armbruster
2020-03-17 16:34 ` [PATCH 0/3] Minor error handling cleanups Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563f6769-74f4-f532-0e76-fe5875742ee1@redhat.com \
--to=eblake@redhat.com \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=paul.durrant@citrix.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).