From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zvfg8-0001Ga-Nb
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:11:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zvfg3-0005ug-Md
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:11:44 -0500
Received: from relay.parallels.com ([195.214.232.42]:46632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zvfg3-0005uW-F0
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:11:39 -0500
References: <563E16AF.8070209@openvz.org>
	<1446910812-13044-1-git-send-email-den@openvz.org>
	<F2CBF3009FA73547804AE4C663CAB28E019A1911@shsmsx102.ccr.corp.intel.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <5640390A.9090606@openvz.org>
Date: Mon, 9 Nov 2015 09:11:22 +0300
MIME-Version: 1.0
In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E019A1911@shsmsx102.ccr.corp.intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] migration: qemu_savevm_state_cleanup
 becomes mandatory operation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Li, Liang Z" <liang.z.li@intel.com>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On 11/09/2015 08:10 AM, Li, Liang Z wrote:
>> since commit
>>      commit 94f5a43704129ca4995aa3385303c5ae225bde42
>>      Author: Liang Li <liang.z.li@intel.com>
>>      Date:   Mon Nov 2 15:37:00 2015 +0800
>>
>>      migration: defer migration_end & blk_mig_cleanup
>>
>> when actual .cleanup callbacks calling was removed from complete operations.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Juan Quintela <quintela@redhat.com>
>> CC: Amit Shah <amit.shah@redhat.com>
>> ---
>>   migration/savevm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/savevm.c b/migration/savevm.c index e05158d..9f2230f
>> 100644
>> --- a/migration/savevm.c
>> +++ b/migration/savevm.c
>> @@ -942,8 +942,8 @@ static int qemu_savevm_state(QEMUFile *f, Error
>> **errp)
>>           qemu_savevm_state_complete(f);
>>           ret = qemu_file_get_error(f);
>>       }
>> +    qemu_savevm_state_cleanup();
>>       if (ret != 0) {
>> -        qemu_savevm_state_cleanup();
>>           error_setg_errno(errp, -ret, "Error while writing VM state");
>>       }
>>       return ret;
>> --
>> 2.5.0
>>
>
> Yes, you are right. Thanks a lot.
>
> BTW, can this patch fix the regression you reported?
>
> Reviewed-by: Liang Li <liang.z.li@intel.com>
>
yes