From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvfnA-0004Q5-E2 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:19:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvfn6-0007Od-Bc for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:19:00 -0500 Received: from relay.parallels.com ([195.214.232.42]:46875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvfn6-0007OY-3u for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:18:56 -0500 References: <563E16AF.8070209@openvz.org> <1446910812-13044-1-git-send-email-den@openvz.org> <5640390A.9090606@openvz.org> From: "Denis V. Lunev" Message-ID: <56403AC1.2080407@openvz.org> Date: Mon, 9 Nov 2015 09:18:41 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] migration: qemu_savevm_state_cleanup becomes mandatory operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Liang Z" Cc: Amit Shah , Paolo Bonzini , "qemu-devel@nongnu.org" , Juan Quintela On 11/09/2015 09:16 AM, Li, Liang Z wrote: >> On 11/09/2015 08:10 AM, Li, Liang Z wrote: >>>> since commit >>>> commit 94f5a43704129ca4995aa3385303c5ae225bde42 >>>> Author: Liang Li >>>> Date: Mon Nov 2 15:37:00 2015 +0800 >>>> >>>> migration: defer migration_end & blk_mig_cleanup >>>> >>>> when actual .cleanup callbacks calling was removed from complete >> operations. >>>> Signed-off-by: Denis V. Lunev >>>> CC: Paolo Bonzini >>>> CC: Juan Quintela >>>> CC: Amit Shah >>>> --- >>>> migration/savevm.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/migration/savevm.c b/migration/savevm.c index >> e05158d..9f2230f >>>> 100644 >>>> --- a/migration/savevm.c >>>> +++ b/migration/savevm.c >>>> @@ -942,8 +942,8 @@ static int qemu_savevm_state(QEMUFile *f, Error >>>> **errp) >>>> qemu_savevm_state_complete(f); >>>> ret = qemu_file_get_error(f); >>>> } >>>> + qemu_savevm_state_cleanup(); >>>> if (ret != 0) { >>>> - qemu_savevm_state_cleanup(); >>>> error_setg_errno(errp, -ret, "Error while writing VM state"); >>>> } >>>> return ret; >>>> -- >>>> 2.5.0 >>>> >>> Yes, you are right. Thanks a lot. >>> >>> BTW, can this patch fix the regression you reported? >>> >>> Reviewed-by: Liang Li >>> >> yes > Great. You'd better change the commit message to make it more clear. > > Liang argh.. you are right... This problem has appeared in the end of big rework of another problem with snapshots and dataplane. Sorry that this is not clear that regression is fixed. I'll resend the patch with better commit message Den