From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvkZF-0005oB-9u for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:24:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvkZC-0008HE-Ll for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:24:57 -0500 Received: from mga02.intel.com ([134.134.136.20]:39423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvkZC-0008H3-GM for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:24:54 -0500 References: <1446184587-142784-1-git-send-email-guangrong.xiao@linux.intel.com> <1446184587-142784-7-git-send-email-guangrong.xiao@linux.intel.com> <20151109130518-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56408101.7050404@linux.intel.com> Date: Mon, 9 Nov 2015 19:18:25 +0800 MIME-Version: 1.0 In-Reply-To: <20151109130518-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 06/33] acpi: add aml_method_serialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/09/2015 07:14 PM, Michael S. Tsirkin wrote: > On Fri, Oct 30, 2015 at 01:56:00PM +0800, Xiao Guangrong wrote: >> It avoid explicit Mutex and will be used by NVDIMM ACPI >> >> Signed-off-by: Xiao Guangrong > > I'd rather you squashed these utility patches in with where > the code is used. This is just making it harder to review > as I have to jump back and forth. Okay to me. > >> --- >> hw/acpi/aml-build.c | 26 ++++++++++++++++++++++++-- >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 25 insertions(+), 2 deletions(-) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9f792ab..8bee8b2 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -696,14 +696,36 @@ Aml *aml_while(Aml *predicate) >> } >> >> /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */ >> -Aml *aml_method(const char *name, int arg_count) >> +static Aml *__aml_method(const char *name, int arg_count, bool serialized) > > Please don't prefix names with __. > what should you call this? > For example, you can call it aml_method_serialized. Igor disliked that aml_method_serialized() is spepated from aml_method(), so i will unify them as a single function instead. :) > >> { >> Aml *var = aml_bundle(0x14 /* MethodOp */, AML_PACKAGE); >> + int methodflags; >> + >> + /* >> + * MethodFlags: >> + * bit 0-2: ArgCount (0-7) >> + * bit 3: SerializeFlag >> + * 0: NotSerialized >> + * 1: Serialized >> + * bit 4-7: reserved (must be 0) >> + */ >> + assert(!(arg_count & ~7)); > > Or shorter assert(arg_count < 8); Good to me.