From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvngh-0002lf-Oh for qemu-devel@nongnu.org; Mon, 09 Nov 2015 09:44:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvngd-0003iV-Ky for qemu-devel@nongnu.org; Mon, 09 Nov 2015 09:44:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvngd-0003iM-5A for qemu-devel@nongnu.org; Mon, 09 Nov 2015 09:44:47 -0500 References: <1446791754-23823-1-git-send-email-eblake@redhat.com> <1446791754-23823-18-git-send-email-eblake@redhat.com> <87611bicbm.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5640B15E.6040207@redhat.com> Date: Mon, 9 Nov 2015 07:44:46 -0700 MIME-Version: 1.0 In-Reply-To: <87611bicbm.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HItJsnVxlc1DTrih15UiI5JVRpHseAWVU" Subject: Re: [Qemu-devel] [PATCH v10 17/30] qapi: Simplify QAPISchemaObjectTypeMember.check() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HItJsnVxlc1DTrih15UiI5JVRpHseAWVU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/09/2015 05:31 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> From: Markus Armbruster >> >> QAPISchemaObjectTypeMember.check() currently does four things: >> >> 4. Check for collisions >> >> This piggyback on 3: before adding a new entry, we assert it's new.= >=20 > piggybacks (typo is mine) What's more, I noticed it in v9, but in redoing v10 to go closer to your original series, I reverted my touchup. Oh well :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HItJsnVxlc1DTrih15UiI5JVRpHseAWVU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQLFeAAoJEKeha0olJ0NqfB8H+wf0vZnaD41AcQPL88v3c/kn vh6jOunUPgGfVSLoQlU7mrCCaLe5OJBeg2lYsgv6USGEiDCjg7C51hIbZ2uvz26R YbNlJEEzH8mcXJ5n3bhaaR43QonTMLwuIIviqtdvWxJsQuZJirPkkbSdfRp+Rfbj ZCYMQ2QmeT7Cg5XDefOuIwdhcsD+/FczWwr9pJPyajG/kgq4IT1l/tgIKYDK6iKL tY1HQD5eFSaW3JnGXVfTmA3DODqv0WEe4czTPkYwNV85SYI2uUqKvGIfaTjkWgY2 jyiAJ1h61DtlVIO9iUw3hk9anIvlmJ96CEWMxbp0T7foKHWOjfHrbx8lAKPey4k= =cQ30 -----END PGP SIGNATURE----- --HItJsnVxlc1DTrih15UiI5JVRpHseAWVU--