From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZvoS0-0004IT-Qj
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:33:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZvoRx-0006fW-ER
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:33:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZvoRx-0006fH-9G
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:33:41 -0500
References: <1447082049-25099-1-git-send-email-peter.maydell@linaro.org>
	<5640BB98.8050001@redhat.com>
	<CAFEAcA-dkuA2k0Pw8MLRc8u13urPuAbQCpF90xMZOY38EPkkFQ@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5640BCCF.30507@redhat.com>
Date: Mon, 9 Nov 2015 16:33:35 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-dkuA2k0Pw8MLRc8u13urPuAbQCpF90xMZOY38EPkkFQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5] configure: Don't disable
 optimization for non-fortify builds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: John Snow <jsnow@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>



On 09/11/2015 16:31, Peter Maydell wrote:
> On 9 November 2015 at 15:28, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 09/11/2015 16:14, Peter Maydell wrote:
>>> Commit b553a0428014636bc inadvertently disabled optimization
>>> for all non-fortify builds. Fix this bug so we only do an
>>> unoptimized build if we want debug.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>>  configure | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/configure b/configure
>>> index b687764..46fd8bd 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4451,6 +4451,8 @@ if test "$gcov" = "yes" ; then
>>>    LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
>>>  elif test "$fortify_source" = "yes" ; then
>>>    CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
>>> +elif test "$debug" = "no"; then
>>> +  CFLAGS="-O2 $CFLAGS"
>>>  fi
>>
>> I think what was intended is:
>>
>> if test "$gcov" = "yes" ; then
>>   CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
>>   LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
>> elif test "$debug" = "no" ; then
>>   if test "$fortify_source" = "yes"; then
>>     CFLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
>>   fi
>>   CFLAGS="-O2 $CFLAGS"
>> fi
>>
>> ... so that --enable-debug does not disable _FORTIFY_SOURCE.
> 
> Commit b553a04280146 specifically sets fortify_source=no
> in the handling of the --enable-debug option, so John
> obviously intended that it should disable _FORTIFY_SOURCE.
> The feature_test_macros(7) manpage says _FORTIFY_SOURCE
> only kicks in at -O1 and above anyway, so that makes sense.

You're right.  The two are the same then, preference is of course
subjective.  Feel free to commit yours!


Paolo