From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtUx-0002vU-KC for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvtUu-0008RU-Ei for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:57:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtUu-0008RP-8d for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:57:04 -0500 References: <1446791754-23823-1-git-send-email-eblake@redhat.com> <1446791754-23823-13-git-send-email-eblake@redhat.com> <87wptvyvk7.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5641089A.7040506@redhat.com> Date: Mon, 9 Nov 2015 13:56:58 -0700 MIME-Version: 1.0 In-Reply-To: <87wptvyvk7.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s7MpcQs16dCRc54quxJDam0jwoPcrbH9C" Subject: Re: [Qemu-devel] [PATCH v10 12/30] qapi-introspect: Document lack of sorting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s7MpcQs16dCRc54quxJDam0jwoPcrbH9C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/06/2015 08:52 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> qapi-code-gen.txt already claims that types, commands, and >> events share a common namespace; set this in stone by further >> documenting that our introspection output will never have >> collisions with the same name tied to more than one meta-type. >> >> For these reasons, we simply document that clients should not >> rely on any particular order of items in introspection output. >> And since it is now a documented part of the contract, we have >> the freedom to later rearrange output if needed, without >> worrying about breaking well-written clients that were already >> aware that they had to do linear searches. >=20 > Well, any kind of search that doesn't rely on sorting. Suggest to drop= > the "that were already..." clause. Happy to do that on commit. I don't see that phrase dropped in your v1 pull request. Worth fixing? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s7MpcQs16dCRc54quxJDam0jwoPcrbH9C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQQiaAAoJEKeha0olJ0NqGqEH/j6N/b6boeuaeiqtXry6l8Jf y4x7zBnUBoC/jcT6y/aOTsItMlT/Ix08V1HSpVdPNpKvkJyZi6x234gN2B/n/Q48 ZqHXjx0A4ygEj9z59RF6WGBmUuiNZosgQ0GdeFH2IPF8j0WTg7SrfU5njDcLRsI9 XnGUkhtqNf2ayHG6wZpbnROk7xvd7lku2sIRS+nQArQjeFY4Fag5VGi5qsL0WrPn RE3941yUvH53TarsDqBLJ9hwiQuu2GOEN3FWiW0SLGeuHdj6a3i72YIHsVn9vyty lvgq+Wi1fn92dwOeJxJDyfa2NxvJ/6MIVdft+d5Qk2yRdskrYkoZwtMCtTcJp+k= =BPyF -----END PGP SIGNATURE----- --s7MpcQs16dCRc54quxJDam0jwoPcrbH9C--