From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvuhX-00056M-Sp for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:14:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvuhU-0006ZZ-KL for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:14:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvuhU-0006ZD-FA for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:14:08 -0500 References: <1447082049-25099-1-git-send-email-peter.maydell@linaro.org> <5640BB98.8050001@redhat.com> From: Eric Blake Message-ID: <56411AA8.6050407@redhat.com> Date: Mon, 9 Nov 2015 15:14:00 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DJt42kP4b4Ug85CGWHV9w18ALWff5qjiv" Subject: Re: [Qemu-devel] [PATCH for-2.5] configure: Don't disable optimization for non-fortify builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Paolo Bonzini Cc: John Snow , QEMU Developers , Patch Tracking This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DJt42kP4b4Ug85CGWHV9w18ALWff5qjiv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/09/2015 08:31 AM, Peter Maydell wrote: > On 9 November 2015 at 15:28, Paolo Bonzini wrote:= >> >> >> On 09/11/2015 16:14, Peter Maydell wrote: >>> Commit b553a0428014636bc inadvertently disabled optimization >>> for all non-fortify builds. Fix this bug so we only do an >>> unoptimized build if we want debug. >>> >=20 > Commit b553a04280146 specifically sets fortify_source=3Dno > in the handling of the --enable-debug option, so John > obviously intended that it should disable _FORTIFY_SOURCE. > The feature_test_macros(7) manpage says _FORTIFY_SOURCE > only kicks in at -O1 and above anyway, so that makes sense. In fact, there are versions of glibc that noisily complain at -O0 if _FORTIFY_SOURCE is enabled. Disabling _FORTIFY_SOURCE when enabling debug is correct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DJt42kP4b4Ug85CGWHV9w18ALWff5qjiv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQRqoAAoJEKeha0olJ0NqNTIIAJ8l3ZisN+vW7KdXrVlvHsTC TwaleOljHrQCPX7PFYnzpasV8fuYFltTz5EeJcUdN9YWf9B39bm7w7SsXUPszoE0 srkGxaPxFQr1/PICscP6xJLq3oGeIlnNlGT33jJGOKmfbOg/qYXN6BiCXjGEUM/3 jKfgVEdgFqPycsSHidiSTIVHLC1tm78mjR3ZlaHzjk07Mnd6kAL4Du1gG6n3Kfpl nh5I3fM09STsNb/+9tG5d5lebfcxKrt9H1LCGS4KROLkin2SeNbvkPi0inWvHrB0 Jt0q24cdoNGNvW8bJIHnstGhiiYU+WEfkUPZeCzXKJhzUDrcGcGxzmWwIFD35nA= =NZSQ -----END PGP SIGNATURE----- --DJt42kP4b4Ug85CGWHV9w18ALWff5qjiv--