From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvun6-0007WV-OQ for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:19:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvun1-0007wF-T5 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:19:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvun1-0007w7-LJ for qemu-devel@nongnu.org; Mon, 09 Nov 2015 17:19:51 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1694D42E5A7 for ; Mon, 9 Nov 2015 22:19:51 +0000 (UTC) References: <1447090141-29074-1-git-send-email-quintela@redhat.com> <1447090141-29074-30-git-send-email-quintela@redhat.com> From: Eric Blake Message-ID: <56411C05.7080609@redhat.com> Date: Mon, 9 Nov 2015 15:19:49 -0700 MIME-Version: 1.0 In-Reply-To: <1447090141-29074-30-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RgGadibhBpvunQo2SSitFKXuLjpnmJqsf" Subject: Re: [Qemu-devel] [PULL 29/57] migrate_start_postcopy: Command to trigger transition to postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RgGadibhBpvunQo2SSitFKXuLjpnmJqsf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding Markus for a qapi question] On 11/09/2015 10:28 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" >=20 > Once postcopy is enabled (with migrate_set_capability), the migration > will still start on precopy mode. To cause a transition into postcopy > the: >=20 > migrate_start_postcopy >=20 > command must be issued. Postcopy will start sometime after this > (when it's next checked in the migration loop). >=20 > Issuing the command before migration has started will error, > and issuing after it has finished is ignored. >=20 > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake > Reviewed-by: Juan Quintela > Reviewed-by: Amit Shah > Signed-off-by: Juan Quintela > --- I know I reviewed an earlier version of this patch, but that was probably before 24/57 of this pull request spelled the migration capability bit as x-postcopy-ram. > +++ b/qapi-schema.json > @@ -702,6 +702,14 @@ > '*tls-port': 'int', '*cert-subject': 'str' } } >=20 > ## > +# @migrate-start-postcopy > +# > +# Switch migration to postcopy mode No documentation on the relation to the [x-]postcopy-ram capability bit? Will this command always fail if that bit is not set? > +# > +# Since: 2.5 > +{ 'command': 'migrate-start-postcopy' } Should we rename this command to 'x-migrate-start-postcopy' until we are ready to rename the entire feature to the stable namespace? If so, I'm okay with that as a followup patch (so as not to delay the pull request), but we should really make up our minds what 2.5 will provide on this front. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RgGadibhBpvunQo2SSitFKXuLjpnmJqsf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQRwGAAoJEKeha0olJ0Nq/lMH/jaHNinXIHVvOBrikcC2d9do bAsWKSQJik27p9ZpP2oW/KbueANclNZxHX+KHshhhPtHBIcgnCdrLbeu+WhT3mED s3Z7RVLiiV5JayXz+Tx06kAaeNRXu336f+5yFPnGqZ4spl3s39AaFLj62VUPA57q ejViUIkMU9k9xB0XTrbz4nb3iLJLKd1p+OZB2aGB6zyhKj75+gZxqBYmH9YAAXpB cfX2kWvLW0oCf8v2xdx3BpA7aviEPQYOepF5AP62fupIj/Fb91o1yMORNtwo6BoB innNmSbeuw4v6UbroKVsYN9uPYHoquPs7JT2HS4RODVpfAwOWsnfj4BtosqJyG0= =YxsH -----END PGP SIGNATURE----- --RgGadibhBpvunQo2SSitFKXuLjpnmJqsf--