From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvzvt-0001iK-BQ for qemu-devel@nongnu.org; Mon, 09 Nov 2015 22:49:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvzvs-0002U9-Bz for qemu-devel@nongnu.org; Mon, 09 Nov 2015 22:49:21 -0500 References: <1447126069-6185-1-git-send-email-mreitz@redhat.com> <5641684C.3090807@redhat.com> From: Max Reitz Message-ID: <56416938.1030505@redhat.com> Date: Tue, 10 Nov 2015 04:49:12 +0100 MIME-Version: 1.0 In-Reply-To: <5641684C.3090807@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aCvT7NkrKvODOKdWe5VmJmj93KOqQBkKK" Subject: Re: [Qemu-devel] [PATCH v2 0/8] blockdev: Further BlockBackend work List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aCvT7NkrKvODOKdWe5VmJmj93KOqQBkKK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10.11.2015 04:45, Eric Blake wrote: > [side question] >=20 > On 11/09/2015 08:27 PM, Max Reitz wrote: >> Overall, this series adds more uses for BlockBackends and makes the co= de >> follow the "reference theory" more closely, in that any BlockBackend >> created (through -drive or blockdev-add) has a reference count of 1, a= nd >> that reference should be held by the monitor. This is reflected here b= y >> introducing an explicit list of monitor-owned BlockBackends, which in >> turn allows us to remove bdrv_states, and, perhaps most importantly, >> blk_hide_on_behalf_of_do_drive_del(). >> >=20 >> Although I don't suppose anyone will care much, here's that >> backport-diff against v1: >> >> Key: >> [----] : patches are identical >> [####] : number of functional differences between upstream/downstream = patch >> [down] : patch is downstream-only >> The flags [FC] indicate (F)unctional and (C)ontextual differences, res= pectively >> >> 001/8:[----] [-C] 'block: Add blk_name_taken()' >> 002/8:[----] [-C] 'block: Add blk_next_inserted()' >> 003/8:[----] [-C] 'block: Add blk_commit_all() and blk_invalidate_cach= e_all()' >> 004/8:[0073] [FC] 'block: Use BlockBackend more' >> 005/8:[0004] [FC] 'blockdev: Add list of monitor-owned BlockBackends' >> 006/8:[down] 'blockdev: Remove blk_hide_on_behalf_of_hmp_drive_del()' >> (renamed from "..._on_behalf_of_do_drive_del()") >=20 > This is a nice note. Is there any way to make 'git backport-diff' > automatically do this, or does it have to be done manually when renamin= g > patches? As far as I know, git backport-diff simply looks for matching patches based on the title alone, so I don't think there's a way for it to automatically figure out name changes. I don't know of a way of telling it that a particular "downstream" patch belongs to another particular "upstream" patch, though. So in general, if I do want an accurate diff even for renamed patches (I did not here, because v1 has been more than eight months ago), I just diff manually and count the changes or temporarily rename the patch on the current (new) branch. Max --aCvT7NkrKvODOKdWe5VmJmj93KOqQBkKK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWQWk4AAoJEDuxQgLoOKytcxwH/iWQ8gMKWVQ3t2YG2pw17zCI Cu/+AeE8eSDsTzNX/Tq5GID/2Xkrbp9hJn7Dh+BSaAU3WV4mGSLUSdDa3kxIsmaI Zn0ZKb8zVCyDY9t+UiqIwwmF/JQpo/MS5l4SHE5GJG7C0NUKM6EdtiPjKKX/rXgN vnV4hUjvo9jT+TBZB6WVZrVYD7DLuwSj6sOrOUwHFdZJ6VFHsOnpPhgC8VPPNDLF iSBOGN73DjoTcl7ueHiuP3jKrLsEwGYyveHUgtu1jaJrE9ZtEL0tUvdzrX8Pp4/y vaOBsjwWdmf5x2Rokw+ocl/UJyc2J3lbg73FEMpo7Q/rMN2/5GX+YQHh3dx2iSU= =bW3q -----END PGP SIGNATURE----- --aCvT7NkrKvODOKdWe5VmJmj93KOqQBkKK--