From: Paolo Bonzini <pbonzini@redhat.com>
To: Rabin Vincent <rabin.vincent@axis.com>, kwolf@redhat.com
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Rabin Vincent <rabinv@axis.com>
Subject: Re: [Qemu-devel] [PATCH] nand: fix address overflow
Date: Tue, 10 Nov 2015 16:09:37 +0100 [thread overview]
Message-ID: <564208B1.7050200@redhat.com> (raw)
In-Reply-To: <1447161947-22542-1-git-send-email-rabin.vincent@axis.com>
On 10/11/2015 14:25, Rabin Vincent wrote:
> The shifts of the address mask and value shift beyond 32 bits when there
> are 5 address cycles.
>
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> ---
> hw/block/nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/nand.c b/hw/block/nand.c
> index 61d2cec..a68266f 100644
> --- a/hw/block/nand.c
> +++ b/hw/block/nand.c
> @@ -522,8 +522,8 @@ void nand_setio(DeviceState *dev, uint32_t value)
>
> if (s->ale) {
> unsigned int shift = s->addrlen * 8;
> - unsigned int mask = ~(0xff << shift);
> - unsigned int v = value << shift;
> + uint64_t mask = ~(0xffull << shift);
> + uint64_t v = (uint64_t)value << shift;
>
> s->addr = (s->addr & mask) | v;
> s->addrlen ++;
>
Cc: qemu-trivial@nongnu.org
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-11-10 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 13:25 [Qemu-devel] [PATCH] nand: fix address overflow Rabin Vincent
2015-11-10 15:09 ` Paolo Bonzini [this message]
2015-11-13 4:23 ` Peter Crosthwaite
2015-11-13 9:32 ` Paolo Bonzini
2015-11-13 11:04 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564208B1.7050200@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).