From: Eric Blake <eblake@redhat.com>
To: Vincenzo Maffione <v.maffione@gmail.com>, qemu-devel@nongnu.org
Cc: g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, jasowang@redhat.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.5 v3 0/2] Fix compilation of netmap backend
Date: Tue, 10 Nov 2015 08:15:58 -0700 [thread overview]
Message-ID: <56420A2E.5090904@redhat.com> (raw)
In-Reply-To: <cover.1447147277.git.v.maffione@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On 11/10/2015 02:47 AM, Vincenzo Maffione wrote:
> This patch series adds some fixes to the netmap net backend. It contains
> two changes:
> (1) Fix compilation issue of netmap.c introduced by the reorganization
> of struct NetClientOptions
> (2) Address the FIXME comment that was asking to use error_setg()
> variants in place of error_report()
>
> CHANGELOG:
> - removed dead return and use error_setg_file_open() in place
> of error_setg_errno()
> - I noticed that net_init_netmap() has to return int, so I restored
> the return statements in that function
>
> Vincenzo Maffione (2):
> net: netmap: Fix compilation issue
> net: netmap: use error_setg() helpers in place of error_report()
Series belongs in 2.5.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-10 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 9:47 [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend Vincenzo Maffione
2015-11-10 9:47 ` [Qemu-devel] [PATCH v3 1/2] net: netmap: Fix compilation issue Vincenzo Maffione
2015-11-10 9:47 ` [Qemu-devel] [PATCH v3 2/2] net: netmap: use error_setg() helpers in place of error_report() Vincenzo Maffione
2015-11-10 15:15 ` Eric Blake [this message]
2015-11-10 15:49 ` [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend Markus Armbruster
2015-11-12 8:19 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56420A2E.5090904@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).