From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwAql-0003s3-SO for qemu-devel@nongnu.org; Tue, 10 Nov 2015 10:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwAqh-0000In-Tj for qemu-devel@nongnu.org; Tue, 10 Nov 2015 10:28:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwAqh-0000Ie-OM for qemu-devel@nongnu.org; Tue, 10 Nov 2015 10:28:43 -0500 References: <1447146556-7328-1-git-send-email-prasanna.kalever@redhat.com> <1447146556-7328-2-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <56420D2A.9020109@redhat.com> Date: Tue, 10 Nov 2015 08:28:42 -0700 MIME-Version: 1.0 In-Reply-To: <1447146556-7328-2-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RLRUn8dGrh5UXUSO9j2dSxScAQQKUEAdU" Subject: Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com, jcody@redhat.com, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RLRUn8dGrh5UXUSO9j2dSxScAQQKUEAdU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multi= ple > gluster servers support. After that, >=20 > an example is, in 'servers' tuple values we use 'server' variable for = key > 'host' in the code, it will be quite messy to have colliding names for > variables, so to maintain better readability and makes it consistent wi= th other > existing code as well as the input keys/options, this patch renames the= > following variables > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' >=20 > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 54 +++++++++++++++++++++++++++----------------------= ----- > 1 file changed, 27 insertions(+), 27 deletions(-) When this has been previously positively reviewed, and you are making no further changes to the code, it speeds up review to add the reviewer's line to your commit message (so that the reviewer knows it is unchanged, and so that other readers know it has been reviewed at least once). Of course, if you change a patch, dropping the R-b line is appropriate. My review from https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04916.html still stands, so that would mean adding: Reviewed-by: Eric Blake to the commit body if you have a reason to post v14 of this series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RLRUn8dGrh5UXUSO9j2dSxScAQQKUEAdU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQg0qAAoJEKeha0olJ0NqEz8H/ikKgBRL9hnxUp7rv3vQpXl0 aO0paQxsA8/4DFGNsPaJBJ3kXWqFHQH1jOGF9cEksYnhWu5bpoG9ArkXEsJNmHDU uIZXOuIqux4QjfWEO86OaLQAlZuJT9miPIh1+cFcSwdLsZOhvPlZP53uc8wa1ofO hnWbMMkgAJInSDXeEDCSpV5DjJtIJJBKuFyAd+SqQ67tm0Z4rn0c+Y9Phg+6ce+R o++jj83fvwLgrYF43pUes+17vE+5VNe3P3BepTVef8/YUOCY+DjlsPj3PsydOeiK xWJyWlR486GjoXl6TZkRZvsb6fSOrwfwE5GTqec+H75scKeXLnZuuwUPwpujEyg= =Df4p -----END PGP SIGNATURE----- --RLRUn8dGrh5UXUSO9j2dSxScAQQKUEAdU--