From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwBug-0001hJ-2u for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:36:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwBua-0006xI-9K for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:36:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwBua-0006x0-2D for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:36:48 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B1992C0AF3DA for ; Tue, 10 Nov 2015 16:36:47 +0000 (UTC) References: <1447090141-29074-1-git-send-email-quintela@redhat.com> <1447090141-29074-30-git-send-email-quintela@redhat.com> <56411C05.7080609@redhat.com> <20151110103839.GB2456@work-vm> From: Eric Blake Message-ID: <56421D1E.6070307@redhat.com> Date: Tue, 10 Nov 2015 09:36:46 -0700 MIME-Version: 1.0 In-Reply-To: <20151110103839.GB2456@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aV3fjxqJW1RRwFwHisClM1CCIggs5CeAr" Subject: Re: [Qemu-devel] [PULL 29/57] migrate_start_postcopy: Command to trigger transition to postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aV3fjxqJW1RRwFwHisClM1CCIggs5CeAr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2015 03:38 AM, Dr. David Alan Gilbert wrote: > * Eric Blake (eblake@redhat.com) wrote: >> [adding Markus for a qapi question] >> >>> >>> ## >>> +# @migrate-start-postcopy >>> +# >>> +# Switch migration to postcopy mode >> >> No documentation on the relation to the [x-]postcopy-ram capability bi= t? >=20 >=20 > One alternative piece of text would be=20 > 'Switch current migration to postcopy mode; the x-postcopy-ram capabili= ty must > be set before issuing this command.' Adding that to the .json would be sufficient for me if you don't feel like naming this x-migrate-start-postcopy - with that sentence, it is then obvious to the reader that this command depends on an experimental prerequisite (and when we later rename x-postcopy-ram to drop the x-, we fix the documentation here). >=20 >>> +# >>> +# Since: 2.5 >>> +{ 'command': 'migrate-start-postcopy' } >> >> Should we rename this command to 'x-migrate-start-postcopy' until we a= re >> ready to rename the entire feature to the stable namespace? >=20 > If you think it's best we could; however I took the 'x-' on the capabil= ity > just to be a flag to indicate it wasn't yet marked as stable; I don't > think we're actually worrying about changes to naming. I just wanted to make sure there was something right there in the migrate-start-postcopy docs that made it obvious that we haven't quite turned this into a fully supported interface yet. Naming it 'x-' does that, but I think it is also okay with just the extra sentence about the pre-req capability bit; and you'll want that sentence anyways even when the capability bit is renamed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aV3fjxqJW1RRwFwHisClM1CCIggs5CeAr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQh0eAAoJEKeha0olJ0NqqLIH/1EKPZ+LioUziG33XXyxxBjL 0msw+VtMhLs8YzJcQA3ipY7Bq/Yaxj6ZwSE6h++SD1cW/KCbUs8fhyuxv71ESwSZ /SIb3r9zsSmdevRFvpraGtrzhmJ09eMfq325xnpYmRPW6B+CtEwY15hvRwpPOJ10 Ag2F1+Pz/oaZWkXW9qcBrYHrlXeEprD7MkXZfRnoh2KX6MHGvkUvrbctNtToKX0+ Oa2HWWzDYv/2aLLDuXBIXcDrCvp45eH0T8D7UFEn0qQTc7n6UFy34tFBUGHMsIzw SpO6PtV5h/886sPaiz/d/MALFWKsVs0p8fkhfv0QRPo4ql1P/J6ZCJ5P65vFOsI= =AST8 -----END PGP SIGNATURE----- --aV3fjxqJW1RRwFwHisClM1CCIggs5CeAr--