From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwChj-0007AA-Bh for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:27:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwChi-0003yR-AW for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:27:35 -0500 References: <41cbcd334a61c6157f0f495cdfd21eff6c156f2a.1446044837.git.berto@igalia.com> From: Eric Blake Message-ID: <564228FD.5080209@redhat.com> Date: Tue, 10 Nov 2015 10:27:25 -0700 MIME-Version: 1.0 In-Reply-To: <41cbcd334a61c6157f0f495cdfd21eff6c156f2a.1446044837.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0xR0MjETL9hqK02JaoCffcepjqMe3rlWk" Subject: Re: [Qemu-devel] [PATCH v4 10/21] block: New option to define the intervals for collecting I/O statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0xR0MjETL9hqK02JaoCffcepjqMe3rlWk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/28/2015 09:33 AM, Alberto Garcia wrote: > The BlockAcctStats structure contains a list of BlockAcctTimedStats. > Each one of these collects statistics about the minimum, maximum and > average latencies of all I/O operations in a certain interval of time. >=20 > This patch adds a new "stats-intervals" option that allows defining > these intervals. >=20 > Signed-off-by: Alberto Garcia > --- > blockdev.c | 37 +++++++++++++++++++++++++++++++++++++ > qapi/block-core.json | 4 ++++ > 2 files changed, 41 insertions(+) > +++ b/qapi/block-core.json > @@ -1503,6 +1503,9 @@ > # @stats-account-failed: #optional whether to include failed > # operations when computing latency and last > # access statistics (default: true) (Since 2.5= ) > +# @stats-intervals: #optional colon-separated list of intervals for > +# collecting I/O statistics, in seconds (default: no= ne) > +# (Since 2.5) > # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1= ) > # (default: off) > # > @@ -1520,6 +1523,7 @@ > '*read-only': 'bool', > '*stats-account-invalid': 'bool', > '*stats-account-failed': 'bool', > + '*stats-intervals': 'str', My fault for not reviewing this change to a .json file prior to the PULL request, but I think this should be '*stats-intervals':['int'] so that we aren't post-processing to parse out colons. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0xR0MjETL9hqK02JaoCffcepjqMe3rlWk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQij9AAoJEKeha0olJ0NqjFYH/3H+ytEPv5qNgGIEShAb1bm5 9D8S5dSySwv7kb1Z5ne+rj5/ju+AgJ4heENawNQaSGphXkpXQ3eStXxir1HWQapE vhTbu793hv9pmUewSCcW2OsxzTBpMJPWWFUSLPnk4w5M0e2SmAiS4hYALU/Wyowv iLb6Nc462IhIhcBZzIW07cj3rEkgUqjl2FNzRobbfvMyFWOaRYXHTMxXS9ma1Of9 WHWlLiFozR3CZ9F0DF6nd43dQWDpp0yBU/sxWgk4TUzjOxSHQGrpnYN6tPfbjJrt acYSa92LTw7SQmIiu3BwLE9wivUre/e88vj0TCdHgAFsFOrKfInof4L6puUng5c= =WVBh -----END PGP SIGNATURE----- --0xR0MjETL9hqK02JaoCffcepjqMe3rlWk--