From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwI2u-0005e4-0F for qemu-devel@nongnu.org; Tue, 10 Nov 2015 18:09:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwI2s-0000va-LZ for qemu-devel@nongnu.org; Tue, 10 Nov 2015 18:09:47 -0500 References: <1447196417-26081-1-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <5642792F.8070601@redhat.com> Date: Tue, 10 Nov 2015 16:09:35 -0700 MIME-Version: 1.0 In-Reply-To: <1447196417-26081-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E6ja0MEQJbKfgck3BhKTrFd9J1qXfflf3" Subject: Re: [Qemu-devel] [PATCH] docs: update bitmaps.md List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E6ja0MEQJbKfgck3BhKTrFd9J1qXfflf3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2015 04:00 PM, John Snow wrote: > Include new error handling scenarios for 2.5. >=20 > Signed-off-by: John Snow > --- > docs/bitmaps.md | 157 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 157 insertions(+) >=20 > diff --git a/docs/bitmaps.md b/docs/bitmaps.md > index 9fd8ea6..a2e8d51 100644 > --- a/docs/bitmaps.md > +++ b/docs/bitmaps.md > @@ -19,12 +19,20 @@ which is included at the end of this document. > * A dirty bitmap's name is unique to the node, but bitmaps attached to= different > nodes can share the same name. > =20 > +* Dirty bitmaps created for internal use by QEMU may be anonymous and = have no > + name, but any user-created bitmaps may not be. There can be any numb= er of > + anonymous bitmaps per node. may not be what? Maybe: Dirty bitmaps ... have no name, but any user-created bitmaps will have a name. There can be... > + > +### Grouped Completion Mode > + > + * Later, QEMU sends notice that the second job has errored out, > + but that the first job was also cancelled: > + ```json > + { "timestamp": { "seconds": 1447193702, "microseconds": 632377= }, > + "data": { "device": "drive1", "action": "report", > + "operation": "read" }, > + "event": "BLOCK_JOB_ERROR" } > + ``` > + > + ```json > + { "timestamp": { "seconds": 1447193702, "microseconds": 640074= }, > + "data": { "speed": 0, "offset": 0, "len": 67108864, > + "error": "Input/output error", > + "device": "drive1", "type": "backup" }, > + "event": "BLOCK_JOB_COMPLETED" } > + ``` So we get both an error and a completion notice on failed jobs? I guess it's because you can configure jobs to report errors but continue on, so the error notification alone doesn't say whether the job ends. > + > + ```json > + { "timestamp": { "seconds": 1447193702, "microseconds": 640163= }, > + "data": { "device": "drive0", "type": "backup", "speed": 0, > + "len": 67108864, "offset": 16777216 }, > + "event": "BLOCK_JOB_CANCELLED" } > + ``` > + Thanks; these examples are very useful. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E6ja0MEQJbKfgck3BhKTrFd9J1qXfflf3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQnkzAAoJEKeha0olJ0NqkJcH/0NhJAzWfO2KNO0y4HWM8VV9 v0y+qct65vJrwZYXKJH7x5mpXlzwe+UHySPhf34IGiSn6/e8IdjN4Z5Q2Y/vXBsz nravDemyE8cekQVjmu6NcIIXSm5eFY9+Se3eVc5kABbwlGVVusuTsmjEC6mtQJ+L xkGIsNlE+N9DvJtIhbmZxJD8nlOZ/kFgo3lPvlfuum+wZkbvEyCrFqrTpEUxsNwl lGRynHbUB2pVKMMn9YK/2IMZpxdRYjk6gF87otfE7ZVcfwAWrvn4rcVpsTnHdmXw /iDCKFTdhCr3d5FBXmMkbfpLtplBrrhl8iCV/FpuxR0oVCHcOKO4t3ZN4y+/7oc= =4+TE -----END PGP SIGNATURE----- --E6ja0MEQJbKfgck3BhKTrFd9J1qXfflf3--