From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwNfT-0007NQ-7P for qemu-devel@nongnu.org; Wed, 11 Nov 2015 00:10:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwNfP-0007ET-Vt for qemu-devel@nongnu.org; Wed, 11 Nov 2015 00:09:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwNfP-0007EP-QE for qemu-devel@nongnu.org; Wed, 11 Nov 2015 00:09:55 -0500 References: <1446128855-26637-1-git-send-email-shannon.zhao@linaro.org> <1446128855-26637-4-git-send-email-shannon.zhao@linaro.org> From: Wei Huang Message-ID: <5642CDA0.8010102@redhat.com> Date: Tue, 10 Nov 2015 23:09:52 -0600 MIME-Version: 1.0 In-Reply-To: <1446128855-26637-4-git-send-email-shannon.zhao@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao , qemu-devel@nongnu.org, peter.maydell@linaro.org, mst@redhat.com, imammedo@redhat.com Cc: peter.huangpeng@huawei.com, zhaoshenglong@huawei.com On 10/29/2015 09:27 AM, Shannon Zhao wrote: > Add power button device in ACPI DSDT table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index ffb9b91..80ce51c 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -339,6 +339,18 @@ static void acpi_dsdt_add_gpio(Aml *scope, const MemMapEntry *gpio_memmap, > aml_append(scope, dev); > } > > +static void acpi_dsdt_add_power_button(Aml *scope) > +{ > + Aml *dev = aml_device("PWRB"); > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > + aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > + aml_append(dev, aml_name_decl("_UID", aml_int(0))); > + Aml *method = aml_method("_STA", 0); > + aml_append(method, aml_return(aml_int(0x0F))); _STA returns 0x0F means PWRB is a functional device; that is good for OSPM. Plus I have tested the whole thing using ACPI-enabled guest VM; that means PWRB was probed correctly. So, Reviewed-by: Wei Huang > + aml_append(dev, method); > + aml_append(scope, dev); > +} > + > /* RSDP */ > static GArray * > build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt) > @@ -553,6 +565,7 @@ build_dsdt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info) > guest_info->use_highmem); > acpi_dsdt_add_gpio(scope, &memmap[VIRT_GPIO], > (irqmap[VIRT_GPIO] + ARM_SPI_BASE)); > + acpi_dsdt_add_power_button(scope); > > aml_append(dsdt, scope); > >