From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwSaq-0000sF-7V for qemu-devel@nongnu.org; Wed, 11 Nov 2015 05:26:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwSZW-0000Gl-LL for qemu-devel@nongnu.org; Wed, 11 Nov 2015 05:25:32 -0500 Sender: Paolo Bonzini References: <1443766573-47401-1-git-send-email-aik@ozlabs.ru> <20151111022728.GF5852@voom.redhat.com> From: Paolo Bonzini Message-ID: <564316B3.7050700@gnu.org> Date: Wed, 11 Nov 2015 11:21:39 +0100 MIME-Version: 1.0 In-Reply-To: <20151111022728.GF5852@voom.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qemu v4] monitor/target-ppc: Define target_get_monitor_def List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, peter.maydell@linaro.org On 11/11/2015 03:27, David Gibson wrote: > Meaning one which adds the hook to the monitor, and another which > implements it for ppc? Maybe. > > I'd like to take this, but I'm not sure whether it's reasonable for > the small generic monitor change to go through the ppc tree. Peter, > Paolo, opinion? I'm not a monitor maintainer, but I think it's okay since there is none. :) We probably should replace target_monitor_defs() with an implementation of target_get_monitor_def on all targets. It can just pass a MonitorDef array to a common function, i.e. int lookup_monitor_def(MonitorDef *def, void *base, const char *name, uint64_t *pval) static int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval) { return lookup_monitor_def(monitor_defs, cs->env_ptr, name, pval); } I don't want you to do it now, but we should add it to the wiki BiteSizedTasks so we don't forget. Paolo