Re: [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements

[Thomas Huth <thuth@redhat.com>]

On 11/11/15 12:25, Cornelia Huck wrote:
> On Tue, 10 Nov 2015 21:16:10 +0100
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> The "return;" statements at the end of functions do not make
>> much sense, so let's remove them.
>>
>> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Richard Henderson <rth@twiddle.net>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  hw/s390x/css.c            |  1 -
>>  hw/s390x/event-facility.c | 21 ++++++---------------
>>  hw/s390x/s390-pci-bus.c   |  4 ----
>>  3 files changed, 6 insertions(+), 20 deletions(-)
>>
> 
> Ack for the css and pci parts.
> 
> The sclp parts, however, switch from "one point of exit" to "immediate
> exit", and I'm not sure I like that; not sure enough anyway to apply
> this patch.

Ah, right, I remember, you're prefering gotos ... well, no, I won't
start a discussion about that here again ;-) ... so feel free to remove
these hunks or simply ignore the patch completely.

 Cheers,
  Thomas