From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ZwXtS-0001w2-FI
	for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:06:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ZwXse-0006Bs-Lm
	for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:05:06 -0500
References: <1447172891-20410-1-git-send-email-berto@igalia.com>
From: Max Reitz <mreitz@redhat.com>
Message-ID: <564366BC.2090309@redhat.com>
Date: Wed, 11 Nov 2015 17:03:08 +0100
MIME-Version: 1.0
In-Reply-To: <1447172891-20410-1-git-send-email-berto@igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="nWW6VMmgOlwivU93aXnPuss5gfsav6eOV"
Subject: Re: [Qemu-devel] [PATCH] iotests: Check for quorum support in test
	139
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nWW6VMmgOlwivU93aXnPuss5gfsav6eOV
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 10.11.2015 17:28, Alberto Garcia wrote:
> The quorum driver is always built in, but it is disabled during
> run-time if there's no SHA256 support available (see commit e94867e).
>=20
> This patch skips the quorum test in iotest 139 in that case.
>=20
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  tests/qemu-iotests/139 | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
> index b5470f7..42f78c7 100644
> --- a/tests/qemu-iotests/139
> +++ b/tests/qemu-iotests/139
> @@ -400,6 +400,8 @@ class TestBlockdevDel(iotests.QMPTestCase):
>          self.checkBlockDriverState('node1', False)
> =20
>      def testQuorum(self):
> +        if not 'quorum' in iotests.qemu_img_pipe('--help'):
> +            return
>          self.addQuorum('quorum0', 'node0', 'node1')
>          # We cannot remove the children of a Quorum device
>          self.delBlockDriverState('node0', expect_error =3D True)

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block


Max


--nWW6VMmgOlwivU93aXnPuss5gfsav6eOV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWQ2a8AAoJEDuxQgLoOKytOx4IAKhQgXUdkvZaYUM0xXnaK1TB
i3xsKp4/VgkXcg9G8g6LOXIRkA2vjqPU2J8PwWpmsJ2EnLcskSTKxckHcTlYCYbU
CIndgx9aHzqqmXgGdvoNCgJShmkwanD++Vlr3VKmskYsJYBBtw21YiILUesa8HgL
bascvGkdSGWE1txMzvsK5AMbeKw4uWPfqJ1+ZG+4gDIhaP29arMxGx3Iy73wszZQ
x0EOrFtj7JxTrV78lgjh7X6BQYDgVz6FZF9kVgtalIHstCKgbXOW2+lT5SGcVKfw
TUrZ6xMMrJh4r0QimKFhePU4DciNleR7VW5SFljM6IoiNO+AvKF7YFgibUy3uKc=
=iW6a
-----END PGP SIGNATURE-----

--nWW6VMmgOlwivU93aXnPuss5gfsav6eOV--