* [Qemu-devel] [PATCH] iotests: Check for quorum support in test 139
@ 2015-11-10 16:28 Alberto Garcia
2015-11-11 16:03 ` Max Reitz
0 siblings, 1 reply; 2+ messages in thread
From: Alberto Garcia @ 2015-11-10 16:28 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Alberto Garcia, Stefan Hajnoczi, qemu-block,
Max Reitz
The quorum driver is always built in, but it is disabled during
run-time if there's no SHA256 support available (see commit e94867e).
This patch skips the quorum test in iotest 139 in that case.
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
tests/qemu-iotests/139 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
index b5470f7..42f78c7 100644
--- a/tests/qemu-iotests/139
+++ b/tests/qemu-iotests/139
@@ -400,6 +400,8 @@ class TestBlockdevDel(iotests.QMPTestCase):
self.checkBlockDriverState('node1', False)
def testQuorum(self):
+ if not 'quorum' in iotests.qemu_img_pipe('--help'):
+ return
self.addQuorum('quorum0', 'node0', 'node1')
# We cannot remove the children of a Quorum device
self.delBlockDriverState('node0', expect_error = True)
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Check for quorum support in test 139
2015-11-10 16:28 [Qemu-devel] [PATCH] iotests: Check for quorum support in test 139 Alberto Garcia
@ 2015-11-11 16:03 ` Max Reitz
0 siblings, 0 replies; 2+ messages in thread
From: Max Reitz @ 2015-11-11 16:03 UTC (permalink / raw)
To: Alberto Garcia, qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi, qemu-block
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On 10.11.2015 17:28, Alberto Garcia wrote:
> The quorum driver is always built in, but it is disabled during
> run-time if there's no SHA256 support available (see commit e94867e).
>
> This patch skips the quorum test in iotest 139 in that case.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> tests/qemu-iotests/139 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
> index b5470f7..42f78c7 100644
> --- a/tests/qemu-iotests/139
> +++ b/tests/qemu-iotests/139
> @@ -400,6 +400,8 @@ class TestBlockdevDel(iotests.QMPTestCase):
> self.checkBlockDriverState('node1', False)
>
> def testQuorum(self):
> + if not 'quorum' in iotests.qemu_img_pipe('--help'):
> + return
> self.addQuorum('quorum0', 'node0', 'node1')
> # We cannot remove the children of a Quorum device
> self.delBlockDriverState('node0', expect_error = True)
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-11 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10 16:28 [Qemu-devel] [PATCH] iotests: Check for quorum support in test 139 Alberto Garcia
2015-11-11 16:03 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).