Re: [Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

On 11/11/2015 07:02 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Improve the text in both the qapi-schema and hmp help to point out
> you need to set the postcopy-ram capability prior to issuing
> migrate-start-postcopy.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  hmp-commands.hx  | 4 +++-
>  qapi-schema.json | 3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)

Does the bit have to be set before starting the migration, or are you
allowed to start the migration, then set the bit, then request the postcopy?

> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 8939b98..3316ee3 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1011,7 +1011,9 @@ ETEXI
>          .name       = "migrate_start_postcopy",
>          .args_type  = "",
>          .params     = "",
> -        .help       = "Switch migration to postcopy mode",
> +        .help       = "Switch current migration to postcopy mode; "
> +                      "the x-postcopy-ram capability must be set before"
> +                      " issuing this command.",

If the bit has to be set before the initial 'migrate' command, it might
read better as:

"Switch a migration that was started with the x-postcopy-ram capability
into postcopy mode"

> +++ b/qapi-schema.json
> @@ -706,7 +706,8 @@
>  ##
>  # @migrate-start-postcopy
>  #
> -# Switch migration to postcopy mode
> +# Switch current migration to postcopy mode; the x-postcopy-ram capability
> +# must be set before issuing this command.

Or maybe even:

"Followup to a migration command to switch the migration to postcopy
mode. The x-postcopy-ram capability must be set before the original
migration command."

But if the capability bit can be set in between the two migration
commands, then your wording is fine and you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]