From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwYLu-0001Lv-F2 for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:34:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwYLr-0005Mr-O9 for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:34:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwYLr-0005Mm-GI for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:34:27 -0500 References: <1447250549-10291-1-git-send-email-dgilbert@redhat.com> <1447250549-10291-4-git-send-email-dgilbert@redhat.com> From: Eric Blake Message-ID: <56436E0D.6040407@redhat.com> Date: Wed, 11 Nov 2015 09:34:21 -0700 MIME-Version: 1.0 In-Reply-To: <1447250549-10291-4-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OGdQL2WfHafF84nVortoFLr4mSKcFPTSG" Subject: Re: [Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com Cc: bharata@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OGdQL2WfHafF84nVortoFLr4mSKcFPTSG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2015 07:02 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > Improve the text in both the qapi-schema and hmp help to point out > you need to set the postcopy-ram capability prior to issuing > migrate-start-postcopy. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 4 +++- > qapi-schema.json | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) Does the bit have to be set before starting the migration, or are you allowed to start the migration, then set the bit, then request the postco= py? >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 8939b98..3316ee3 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1011,7 +1011,9 @@ ETEXI > .name =3D "migrate_start_postcopy", > .args_type =3D "", > .params =3D "", > - .help =3D "Switch migration to postcopy mode", > + .help =3D "Switch current migration to postcopy mode; " > + "the x-postcopy-ram capability must be set befor= e" > + " issuing this command.", If the bit has to be set before the initial 'migrate' command, it might read better as: "Switch a migration that was started with the x-postcopy-ram capability into postcopy mode" > +++ b/qapi-schema.json > @@ -706,7 +706,8 @@ > ## > # @migrate-start-postcopy > # > -# Switch migration to postcopy mode > +# Switch current migration to postcopy mode; the x-postcopy-ram capabi= lity > +# must be set before issuing this command. Or maybe even: "Followup to a migration command to switch the migration to postcopy mode. The x-postcopy-ram capability must be set before the original migration command." But if the capability bit can be set in between the two migration commands, then your wording is fine and you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OGdQL2WfHafF84nVortoFLr4mSKcFPTSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQ24NAAoJEKeha0olJ0Nq8gwIAKxafumqubxf2cixD/l9jFXE nY2RUNkxIctm1PgynI49BwbD+tuazZPDuCOf6MoaxJrztYPIpsM8GWPHxMm6W8XB yeD5Eqs/MU755Cf5+SElhsbNdNFQygvJuvkpjo7pjKxt+txfA88L90kOWI4m7dy+ pYJZO5NBnyf5Vx8PcAqXzFdVhr2cK2szfgu6swGSYPEEAiUzJNsZqAlgsfcfhLOb h2TN57Dn/7vWxNTzX21rwxd3tywgufvUiDhXqzy11+/jklxGtU7bF9tmPhyZzh2Q 8fSLW+jKjEM+nXIUAC4jFJr5g6oDYwBPeTnC0BacMWiYFKNxDrMUJTQdb29bRUA= =bo7b -----END PGP SIGNATURE----- --OGdQL2WfHafF84nVortoFLr4mSKcFPTSG--