From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwZSc-0000r1-Le for qemu-devel@nongnu.org; Wed, 11 Nov 2015 12:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwZSL-0001xu-Tt for qemu-devel@nongnu.org; Wed, 11 Nov 2015 12:45:30 -0500 References: <1447224690-9743-1-git-send-email-eblake@redhat.com> <1447224690-9743-19-git-send-email-eblake@redhat.com> <87si4cboqt.fsf@blackfin.pond.sub.org> <56436A90.3010301@redhat.com> <87fv0c5tok.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56437E87.7040803@redhat.com> Date: Wed, 11 Nov 2015 10:44:39 -0700 MIME-Version: 1.0 In-Reply-To: <87fv0c5tok.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9DnxkP952ldGVA1qQmMvflDdINgJOtppm" Subject: Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Jiri Pirko , Eduardo Habkost , "open list:Block layer core" , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Scott Feldman , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9DnxkP952ldGVA1qQmMvflDdINgJOtppm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2015 10:31 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 11/11/2015 07:21 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> >>>> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >>>> since c6bd8c706. Nuke them. >>> >>> Doesn't really belong to this series, but that's okay. >> >> If you're going to modify this for 2.5 inclusion through your qerror >> tree, you may want to change the description to: >=20 > I'll try to get this into 2.5 mostly for the documentation update. >=20 >> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) were missed in >> c6bd8c706, or have snuck in since. Nuke them. >=20 > Done. Oh, and I missed your capitalization preferences in the title: qerror: More error_setg() usage >> There's also the question if we want to address the ErrorClass name >> munging of 19/28 by adding your idea of an aliasing typedef in error.h= ; >> if so, should I prepare a smaller patch series of both of those change= s >> for consideration for 2.5? >=20 > Can safely wait for 2.6, can't it? Yes. Just trying to make sure I'm focusing on 2.5 patches first. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9DnxkP952ldGVA1qQmMvflDdINgJOtppm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQ36HAAoJEKeha0olJ0NqKXcIAKwDSAPH+fA+8bGH1vtFPoSi ksgMMY3v2Vfj5HM1OklQYPHQMILc9TlCdrLPqk2x3cblkzZVE4lxR6lEq0rWx628 EzaO2Dc+G1moQvVMo2JCyEW9a9ujDrfrpgj6+PegOOORHi+bIQlpM6/FpjmQBPlx 34/w5ZVldWyQpjFJLTfJDy1xoLFZM9IHlBK+rQARMoUxHFVFZDVi8y/S2gmzgvlf i0uOVAtHP3R1Bp2CUVXBcNmQPVJdsRNbFk53XfTcK9CIF2pmJcwTiNpIGcsg5iFP fQKeGgD0p55K9RvwS/9apWBBX+i4GhkKNMdV4CaR2TJzLmX7qUW0BZMm/xXl+TM= =hNA/ -----END PGP SIGNATURE----- --9DnxkP952ldGVA1qQmMvflDdINgJOtppm--