From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwbRZ-0001AY-Gd for qemu-devel@nongnu.org; Wed, 11 Nov 2015 14:52:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwbRP-0008Mx-HZ for qemu-devel@nongnu.org; Wed, 11 Nov 2015 14:52:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:45297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwbRP-0008Mq-CD for qemu-devel@nongnu.org; Wed, 11 Nov 2015 14:52:23 -0500 References: <1443184788-18859-1-git-send-email-afaerber@suse.de> <1443184788-18859-5-git-send-email-afaerber@suse.de> <20150925150136.GF13579@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56439C75.1060309@suse.de> Date: Wed, 11 Nov 2015 20:52:21 +0100 MIME-Version: 1.0 In-Reply-To: <20150925150136.GF13579@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Markus Armbruster , Michael Roth , Bruce Rogers , Lin Ma , Paolo Bonzini Am 25.09.2015 um 17:01 schrieb Daniel P. Berrange: > On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas F=C3=A4rber wrote: >> Add a test for parsing and setting a uint64 property. >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> MAINTAINERS | 1 + >> tests/Makefile | 3 ++ >> tests/check-qom-props.c | 120 +++++++++++++++++++++++++++++++++++++++= +++++++++ >> 3 files changed, 124 insertions(+) >> create mode 100644 tests/check-qom-props.c >=20 > FWIW, back in commit a31bdae5a76ecc060c1eb8a66be1896072c1e8b2 I added > a check-qom-proplist.c unit test, and later extended it with test > for enums. That's where your copyright and authorship came from. > Perhaps your addition is best placed in there, or we could > rename that test to check-qom-props.c so we just have one file for all > property unit testing I can only guess that my dislike was "/qom/proplist" as my test has nothing to do with lists. Otherwise it looks similar enough. I'll rename it and merge the two. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)