From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43314)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Zwp0B-00077x-7z
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 05:21:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Zwp09-0004I4-D4
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 05:21:11 -0500
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:52598 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Zwp09-0004Hn-44
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 05:21:09 -0500
References: <1446799373-6144-1-git-send-email-pl@kamp.de>
	<1446799373-6144-4-git-send-email-pl@kamp.de>
	<20151112095736.GS4082@ad.usersys.redhat.com>
From: Peter Lieven <pl@kamp.de>
Message-ID: <5644680E.4000000@kamp.de>
Date: Thu, 12 Nov 2015 11:21:02 +0100
MIME-Version: 1.0
In-Reply-To: <20151112095736.GS4082@ad.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 3/6] ide: add support for
 IDEBufferedRequest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@gmail.com, jcody@redhat.com, qemu-devel@nongnu.org, jsnow@redhat.com

Am 12.11.2015 um 10:57 schrieb Fam Zheng:
> On Fri, 11/06 09:42, Peter Lieven wrote:
>> +BlockAIOCB *ide_buffered_readv(IDEState *s, int64_t sector_num,
>> +                               QEMUIOVector *iov, int nb_sectors,
>> +                               BlockCompletionFunc *cb, void *opaque)
>> +{
>> +    BlockAIOCB *aioreq;
>> +    IDEBufferedRequest *req;
>> +    int c = 0;
>> +
>> +    QLIST_FOREACH(req, &s->buffered_requests, list) {
>> +        c++;
>> +    }
>> +    if (c > MAX_BUFFERED_REQS) {
>> +        return blk_abort_aio_request(s->blk, cb, opaque, -EIO);
>> +    }
>> +
>> +    req = g_new0(IDEBufferedRequest, 1);
>> +    req->original_qiov = iov;
>> +    req->original_cb = cb;
>> +    req->original_opaque = opaque;
>> +    req->iov.iov_base = qemu_blockalign(blk_bs(s->blk), iov->size);
> Where is this bounce buffer freed?

Oops, during conversion form req->buf to req->iov this got lost.
It should be freed in ide_buffered_readv_cb.

I will respin after you had a look at the other patches as well.

Thanks,
Peter