From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwrrm-0004HL-IZ for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:24:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwrrj-0007lE-5S for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:24:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwrrj-0007lA-15 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:24:39 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B2CA68E93C for ; Thu, 12 Nov 2015 13:24:38 +0000 (UTC) References: <1447279028-2114-1-git-send-email-eblake@redhat.com> <1447279028-2114-2-git-send-email-eblake@redhat.com> <87bnazvd78.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56449311.4010802@redhat.com> Date: Thu, 12 Nov 2015 06:24:33 -0700 MIME-Version: 1.0 In-Reply-To: <87bnazvd78.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hiKPOidCNOTqmxEBh3RDVHitiVb8v6kH4" Subject: Re: [Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hiKPOidCNOTqmxEBh3RDVHitiVb8v6kH4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/12/2015 01:23 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Our documentation states that we prefer 'lower-case', rather than >> 'CamelCase', for qapi enum values. The InputButton and InputAxis >> enums violated this convention. However, they are currently used >> primarily for generating code that is used internally; their only >> exposure through QMP is via the experimental 'x-input-send-event' >> command. Since this is experimental, changing the QMP wire format >> for that command is acceptable. >=20 > I can take this through my tree if Gerd doesn't object. If we aren't changing the spelling of x-, then we shouldn't change the spelling of the arguments to x-. How about this instead: add a FIXME comment to qapi-schema.json that documents that the names of the enum values will likely be changed at the (later) point where x- is removed. In the meantime, if we add any namespace enforcing, we'll just have to whitelist these two. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hiKPOidCNOTqmxEBh3RDVHitiVb8v6kH4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWRJMRAAoJEKeha0olJ0NqMOQH/R3kc9YhQywJ7X99/3TaITjs YjNlmzWJrhe2FAOqyvv4WPjNg90Nde8cA8FRIqCTOB1PnLqBD8Mj0c2fgiTx+SYn Ri6ak90Z30koGvLuPAZdrcsNH4pTNJyHNJXo26gtTOGR8u68uXujuwb6Z5JpZCtz eh9I5lDbw9zN2o/361ba0ckwtyMzGaLD/3sDTiFlEra9q7i8kbA/jH3CHXiLR5vW yRR756LyaAm81p6X0J0jrRc29PU4mTlAehrTncDZD0TNRET03DaBhvMwMywfIO/E 3IFbmT58iekXqX4lMOqvK1qmEAiMAHQq+yzU6/G5BONnYEWlwLTIuUQBkTsxuIc= =f6Zk -----END PGP SIGNATURE----- --hiKPOidCNOTqmxEBh3RDVHitiVb8v6kH4--