From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtdV-0006Nf-05 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:18:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwtdS-0002QV-AJ for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:18:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtdS-0002QR-4t for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:18:02 -0500 References: <1447328084-11563-1-git-send-email-dgilbert@redhat.com> From: Eric Blake Message-ID: <5644ADA2.5090505@redhat.com> Date: Thu, 12 Nov 2015 08:17:54 -0700 MIME-Version: 1.0 In-Reply-To: <1447328084-11563-1-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5iT9BmvKEPR5WfPiB6HSxMBJ7cCj15IcN" Subject: Re: [Qemu-devel] [PATCH v2 1/1] migrate-start-postcopy: Improve text List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com Cc: borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5iT9BmvKEPR5WfPiB6HSxMBJ7cCj15IcN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/12/2015 04:34 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > Improve the text in both the qapi-schema and hmp help to point out > you need to set the postcopy-ram capability prior to issuing > migrate-start-postcopy. >=20 > Also fix the text of the migrate_start_postcopy error that > deals with capabilities. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > v2 > Updated text to Erik's suggestion It's Eric, but you're not the first (nor the last) to make that typo. > +++ b/qapi-schema.json > @@ -706,7 +706,9 @@ > ## > # @migrate-start-postcopy > # > -# Switch migration to postcopy mode > +# Followup to a migration command to switch the migration to postcopy = mode. Maybe "Followup to the migrate command to switch the migration..." But the wording you have also covers the case if we add something other than just 'migrate' to start a migration, so I'm fine either way. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5iT9BmvKEPR5WfPiB6HSxMBJ7cCj15IcN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWRK2iAAoJEKeha0olJ0Nqf7MH/38Jle7HsFc3g0qkUKmEyaj5 rkzv0QTAcD7d/Bp6bimc9Ovlm1JUjQkgNG8J9FiJwcsJav+NdkcLKCrVmWEAdEKt JmehRYJ9F1OSfGDgJrgGlJCan/o3/5WrRUnfxINKlrZW0bbBKIbPc+/9MWN9IJ8o 3xSK9TzNTlBPcYMRmF9R76kUQiHQgdA386tqYdrmmKmfg8sSGETscnznchgMigYj BcEJlnayZWma7Cp8HftYcvY0YwVrf2C5MsUnK2O9EDfo+uTY9P3yBgvFF2Ex+ehX psA7NYagXE+hDaLRwbUwYeuRBAVx+/cih4gqoyvx+6KgWTcyso+UXgnQowUxpp0= =SsrM -----END PGP SIGNATURE----- --5iT9BmvKEPR5WfPiB6HSxMBJ7cCj15IcN--